[JCR-2671] AbstractLoginModule must not call abort() in commit()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0, 2.1
• Fix Version/s: 2.1.1, 2.2
• Component/s: jackrabbit-core
• Assignee: Unassigned
• Reporter: Marcel Reutegger
• Created: 02/Jul/10 12:20
• Updated: 12/Aug/10 08:40
• Resolved: 07/Jul/10 19:48

Description

AbstractLoginModule.commit() currently may call abort() when it detects that the login did not succeed. abort() will reset any state in the login module, including state shared between multiple login modules like Principals in the Subject. When there actually are multiple module, this will delete shared state that was set by other login modules. Moreover, the method commit() is only called when the overall authentication succeeded. Thus, it seems strange to call abort() from within commit().