Details

      Issue Links

        Activity

        Hide
        angela added a comment -

        applied slightly modified patch provided by uwe jaeger.

        • i didn't include the PROPFIND functionality but created a new issue JCR-2948
          for this which depends on JCR-2946
        • in addition i added a draft version for unregistration of node types (which then fails in jackrabbit-core).

        final note: i would like to review this in a calm moment... somehow i'm not yet convinced that this is the way to go... maybe i will find some time in the future to update my webdav-jcr mapping document... that would help me to think carefully about it. leaving it for the time being and resolving the issue.

        Show
        angela added a comment - applied slightly modified patch provided by uwe jaeger. i didn't include the PROPFIND functionality but created a new issue JCR-2948 for this which depends on JCR-2946 in addition i added a draft version for unregistration of node types (which then fails in jackrabbit-core). final note: i would like to review this in a calm moment... somehow i'm not yet convinced that this is the way to go... maybe i will find some time in the future to update my webdav-jcr mapping document... that would help me to think carefully about it. leaving it for the time being and resolving the issue.
        Hide
        Uwe Jäger added a comment -

        Hi,
        please find the slightly changed patch attached. One major change: PROPFIND for nodetypes-cnd was implemented. In order to use CompactNodeTypeDefWriter jackrabbit-jcr-server needs to depend on jackrabbit-spi and jackrabbit-spi-commons (not sure if that's a problem).
        Also the client now sends the allowUpdate-Flag (is not a problem for the JAVA client as this is already checked on the client side, but other clients have to set it now).

        If there any further comments, let me know.

        Kind regards
        Uwe

        Show
        Uwe Jäger added a comment - Hi, please find the slightly changed patch attached. One major change: PROPFIND for nodetypes-cnd was implemented. In order to use CompactNodeTypeDefWriter jackrabbit-jcr-server needs to depend on jackrabbit-spi and jackrabbit-spi-commons (not sure if that's a problem). Also the client now sends the allowUpdate-Flag (is not a problem for the JAVA client as this is already checked on the client side, but other clients have to set it now). If there any further comments, let me know. Kind regards Uwe
        Hide
        Uwe Jäger added a comment -

        Reworked the patch for tests, PROPFIND and allowUpdate

        Show
        Uwe Jäger added a comment - Reworked the patch for tests, PROPFIND and allowUpdate
        Hide
        Uwe Jäger added a comment -

        Hi,

        OK I found the place to start I assume a PROPFIND for JCR_NODETYPES_CND_LN on the workspace should return a CND representation of all registered node types (this is in analogy to the namespaces) - 404 else (what it already does).

        kind regards
        Uwe

        Show
        Uwe Jäger added a comment - Hi, OK I found the place to start I assume a PROPFIND for JCR_NODETYPES_CND_LN on the workspace should return a CND representation of all registered node types (this is in analogy to the namespaces) - 404 else (what it already does). kind regards Uwe
        Show
        angela added a comment - http://www.webdav.org/specs/rfc4918.html#METHOD_PROPFIND http://www.webdav.org/specs/rfc4918.html#METHOD_PROPPATCH
        Hide
        Uwe Jäger added a comment -

        hi angela,

        while b) is clear and seems to be ok with just uncommenting the tests if have actually no clue what I should do for a). Please give me a pointer where to start ...

        kind regards
        Uwe

        Show
        Uwe Jäger added a comment - hi angela, while b) is clear and seems to be ok with just uncommenting the tests if have actually no clue what I should do for a). Please give me a pointer where to start ... kind regards Uwe
        Hide
        angela added a comment -

        hi uwe

        thanks a lot for the patch. looks good.
        i only have 1 minor issues:

        a) could you (for completeness) handle the JCR_NODETYPES_CND_LN property upon PROPFIND as well?
        b) the jcr tests related to node type registration are still commented in jcr2dav/pom.xml and spi2dav/pom.xml [1]
        could you uncomment those as part of the patch and make sure that they pass? that would be great.

        thanks in advance
        angela

        [1] the commented tests:

        <!-- JCR-2454 : node type registration -->
        org.apache.jackrabbit.test.api.nodetype.NodeTypeCreationTest#testRegisterNodeType
        org.apache.jackrabbit.test.api.nodetype.NodeTypeCreationTest#testRegisterNodeTypes

        Show
        angela added a comment - hi uwe thanks a lot for the patch. looks good. i only have 1 minor issues: a) could you (for completeness) handle the JCR_NODETYPES_CND_LN property upon PROPFIND as well? b) the jcr tests related to node type registration are still commented in jcr2dav/pom.xml and spi2dav/pom.xml [1] could you uncomment those as part of the patch and make sure that they pass? that would be great. thanks in advance angela [1] the commented tests: <!-- JCR-2454 : node type registration --> org.apache.jackrabbit.test.api.nodetype.NodeTypeCreationTest#testRegisterNodeType org.apache.jackrabbit.test.api.nodetype.NodeTypeCreationTest#testRegisterNodeTypes
        Hide
        David Buchmann added a comment - - edited

        awesome, thanks uwe! would love to see this integrated. just tested it on the trunk branch for 2.3 and it works fine.

        one note for the record: this is only working to create node types or add properties. non-trivial operations (i.e. removing a property of a node type) lead to an exception in the cnd handling code, just as happens when you try to do such a change from the cli.

        Show
        David Buchmann added a comment - - edited awesome, thanks uwe! would love to see this integrated. just tested it on the trunk branch for 2.3 and it works fine. one note for the record: this is only working to create node types or add properties. non-trivial operations (i.e. removing a property of a node type) lead to an exception in the cnd handling code, just as happens when you try to do such a change from the cli.
        Hide
        Uwe Jäger added a comment -

        This patch implements the missing feature

        Show
        Uwe Jäger added a comment - This patch implements the missing feature
        Hide
        Uwe Jäger added a comment -

        This patch implements the missing feature. We would love to see this soon in a release (2.2.6 or 2.3). Then we no longer need to use a patched version.

        Show
        Uwe Jäger added a comment - This patch implements the missing feature. We would love to see this soon in a release (2.2.6 or 2.3). Then we no longer need to use a patched version.
        Hide
        Amit Jain added a comment -

        When is this planned? Any estimate for fixing this?

        Show
        Amit Jain added a comment - When is this planned? Any estimate for fixing this?
        Hide
        angela added a comment -

        adjusting summary as it only affects spi2dav(ex) - jcr-server

        Show
        angela added a comment - adjusting summary as it only affects spi2dav(ex) - jcr-server
        Hide
        angela added a comment -

        TODO:

        registration of node types is the only left task.

        Show
        angela added a comment - TODO: registration of node types is the only left task.
        Hide
        Marcel Reutegger added a comment -

        +1 for postponing.

        Show
        Marcel Reutegger added a comment - +1 for postponing.
        Hide
        Jukka Zitting added a comment -

        Do we need this for 2.0 or can we postpone to a later release?

        Show
        Jukka Zitting added a comment - Do we need this for 2.0 or can we postpone to a later release?
        Hide
        angela added a comment -

        can't reopen the original [JSR 283 NodeType Management] subtask which was closed premature.
        the spi2dav still misses the implementation and so does the server-side part.

        Show
        angela added a comment - can't reopen the original [JSR 283 NodeType Management] subtask which was closed premature. the spi2dav still misses the implementation and so does the server-side part.

          People

          • Assignee:
            angela
            Reporter:
            angela
          • Votes:
            4 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development