[JCR-2168] Avoid premature publication of XAItemStateManager

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.6
• Fix Version/s: 1.5.7
• Component/s: jackrabbit-core
• Assignee: Unassigned
• Reporter: Martijn Hendriks
• Created: 22/Jun/09 10:41
• Updated: 05/Aug/09 15:05
• Resolved: 29/Jun/09 08:32

Description

The XAItemStateManager constructor calls the super constructor (LocalItemStateManager) which registers the instance as a listener with the SharedItemStateManager. The construction of the instance has not yet been finished, but it is accessible from the SharedItemStateManager. This can result in strange exceptions like the following:

java.lang.NullPointerException
at org.apache.jackrabbit.core.state.XAItemStateManager.stateModified(XAItemStateManager.java:580)
at org.apache.jackrabbit.core.state.StateChangeDispatcher.notifyStateModified(StateChangeDispatcher.java:111)
at org.apache.jackrabbit.core.state.SharedItemStateManager.stateModified(SharedItemStateManager.java:400)
at org.apache.jackrabbit.core.virtual.AbstractVISProvider.stateModified(AbstractVISProvider.java:445)
at org.apache.jackrabbit.core.state.ItemState.notifyStateUpdated(ItemState.java:244)

The NPE is caused by the commitLogs field being null (it has not yet been initialized to its final value).