[JCR-2067] FileDataStore: only open a stream when really necessary

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6
• Component/s: jackrabbit-core
• Assignee: Thomas Mueller
• Reporter: Thomas Mueller
• Created: 09/Apr/09 09:58
• Updated: 13/Aug/09 15:03
• Resolved: 27/May/09 10:19

Description

Currently, PropertyImpl.getValue() opens a FileInputStream if the FileDataStore is used.
If the application doesn't use the value, this stream is never closed.

PropertyImpl.getValue():
return internalGetValue().toJCRValue(session);
InternalValue.toJCRValue(..):
case PropertyType.BINARY:
return new BinaryValue(((BLOBFileValue) val).getStream());
BLOBInDataStore.getStream():
return getDataRecord().getStream();
FileDataRecord.getStream():
return new FileInputStream(file);

One solution is to return a 'lazy' file input stream that only opens the file when reading from the stream (and closing the file when the last byte was read). Maybe there is already a class (in Apache Commons maybe?) that can do that.