Uploaded image for project: 'Jackrabbit Content Repository'
  1. Jackrabbit Content Repository
  2. JCR-1330

repository.xml DTD doesn't allow <DataStore> element

    Details

      Description

      The repository.xml DTD at http://jackrabbit.apache.org/dtd/repository-1.4.dtd conflicts with the instructions in the wiki page at http://wiki.apache.org/jackrabbit/DataStore

      Adding the <DataStore> element as specified in the wiki page violates the DTD.

        Activity

        Hide
        jukkaz Jukka Zitting added a comment -

        The updated file is now on http://jackrabbit.apache.org/

        Show
        jukkaz Jukka Zitting added a comment - The updated file is now on http://jackrabbit.apache.org/
        Hide
        jukkaz Jukka Zitting added a comment -

        Merged the jackrabbit-core change to the 1.4 branch in revision 638056.

        Show
        jukkaz Jukka Zitting added a comment - Merged the jackrabbit-core change to the 1.4 branch in revision 638056.
        Hide
        tmueller Thomas Mueller added a comment -

        Committed in revision 637936 to jackrabbit-core (commit 614128 was in jackrabbit-site)

        Show
        tmueller Thomas Mueller added a comment - Committed in revision 637936 to jackrabbit-core (commit 614128 was in jackrabbit-site)
        Hide
        tmueller Thomas Mueller added a comment -

        I just saw there is a second dtd file in
        jackrabbit-core
        src/main/resources/org/apache/jackrabbit\core/config
        repository-1.4.dtd
        that has not been changed.

        Also, the file
        http://jackrabbit.apache.org/dtd/repository-1.4.dtd
        is not updated yet

        Show
        tmueller Thomas Mueller added a comment - I just saw there is a second dtd file in jackrabbit-core src/main/resources/org/apache/jackrabbit\core/config repository-1.4.dtd that has not been changed. Also, the file http://jackrabbit.apache.org/dtd/repository-1.4.dtd is not updated yet
        Hide
        tmueller Thomas Mueller added a comment -

        DTD committed in revision 614128 (trunk) and 614129 (branch 1.4).

        Show
        tmueller Thomas Mueller added a comment - DTD committed in revision 614128 (trunk) and 614129 (branch 1.4).
        Hide
        tmueller Thomas Mueller added a comment -

        Hi Esteban,

        The system property org.jackrabbit.useDataStore is a 'kill switch' to disable the new code in InternalValue and do everything as before (not using BLOBInMemory and so on). This property should never be switched off, except if there is a problem with the data store, and you want to check if the new code is to blame. I don't think it is needed any longer, I will remove this property (and the old code) in the trunk.

        Show
        tmueller Thomas Mueller added a comment - Hi Esteban, The system property org.jackrabbit.useDataStore is a 'kill switch' to disable the new code in InternalValue and do everything as before (not using BLOBInMemory and so on). This property should never be switched off, except if there is a problem with the data store, and you want to check if the new code is to blame. I don't think it is needed any longer, I will remove this property (and the old code) in the trunk.
        Hide
        efranqueiro Esteban Franqueiro added a comment -

        Shouldn't the org.jackrabbit.useDataStore system property be documented in the wiki too? Because although in RepositoryImpl's constructor it is asserted true in case the data store config is not null, in InternalValue it's used regardless of the case. So if the data store is not configured but the property is true (which is it's default value) then the processing in InternalValue is wrong. IMHO, this property should be removed altogether.
        Regards

        Show
        efranqueiro Esteban Franqueiro added a comment - Shouldn't the org.jackrabbit.useDataStore system property be documented in the wiki too? Because although in RepositoryImpl's constructor it is asserted true in case the data store config is not null, in InternalValue it's used regardless of the case. So if the data store is not configured but the property is true (which is it's default value) then the processing in InternalValue is wrong. IMHO, this property should be removed altogether. Regards
        Hide
        enorman Eric Norman added a comment -

        proposed repository-1.4.dtd file that includes the DataStore element definition

        Show
        enorman Eric Norman added a comment - proposed repository-1.4.dtd file that includes the DataStore element definition

          People

          • Assignee:
            tmueller Thomas Mueller
            Reporter:
            enorman Eric Norman
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development