[JCR-1308] Unnecessary null check in EffectiveNodeType.getApplicableChildNodeDef()

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5
• Component/s: jackrabbit-core
• Assignee: Jukka Zitting
• Reporter: Ed Burnette
• Created: 11/Jan/08 13:30
• Updated: 08/Dec/08 11:09
• Resolved: 02/Sep/08 17:23

Description

This is just a trivial thing I noticed this while inspecting the code. getApplicableChildNodeDef() says:

// try named node definitions first
ItemDef[] defs = getNamedItemDefs(name);
if (defs != null) {

but getNamedItemDefs() is currently defined to not return null:

public ItemDef[] getNamedItemDefs(Name name) {
List defs = (List) namedItemDefs.get(name);
if (defs == null || defs.size() == 0)

{ return ItemDef.EMPTY_ARRAY; }

return (ItemDef[]) defs.toArray(new ItemDef[defs.size()]);
}

I didn't check to see if there were any other unnecessary null checks.