Jackrabbit Content Repository
  1. Jackrabbit Content Repository
  2. JCR-1304

Support system properties in ${...} vars in XML config files

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: config, jackrabbit-core
    • Labels:
      None

      Description

      The variable replacement ($

      {...}

      ) in config files like repository.xml currently only allows for the special variables introduced by Jackrabbit, eg. $

      {wsp.name}

      or $

      {rep.home}

      . But it would be useful to support all java system properties here as it is some kind of a standard in Java XML config files (see Spring for an example).

      This makes it easier to inject variables from outside the config file, eg. by setting them on the command line or injecting them programmatically in test cases. Typical parameters for that include database connection credentials, which one wants to avoid to put into repository.xml files that are often checked into SVN.

      This is especially true for test cases, eg. I currently work on a persistence manager component and I want to include the repository.xml in the source tree (under applications/test) but without my specific credentials. These are applied by loading a user-specific properties file through the test case before the repository is started and the config is read.

      1. enable-system-props-in-config-vars.patch
        1 kB
        Alexander Klimetschek
      2. JCR-1304.patch
        1 kB
        Jukka Zitting
      3. JCR-1304.patch
        0.8 kB
        Jukka Zitting

        Issue Links

          Activity

          Alexander Klimetschek created issue -
          Alexander Klimetschek made changes -
          Field Original Value New Value
          Attachment enable-system-props-in-config-vars.patch [ 12372901 ]
          Jukka Zitting made changes -
          Attachment JCR-1304.patch [ 12372906 ]
          Jukka Zitting made changes -
          Attachment JCR-1304.patch [ 12372908 ]
          Jukka Zitting made changes -
          Fix Version/s 1.4 [ 12312447 ]
          Component/s jackrabbit-core [ 12310114 ]
          Assignee Jukka Zitting [ jukkaz ]
          Priority Major [ 3 ] Minor [ 4 ]
          Affects Version/s 1.5 [ 12312920 ]
          Affects Version/s 1.4 [ 12312447 ]
          Affects Version/s 1.3.3 [ 12312770 ]
          Component/s jackrabbit-jcr-commons [ 12312057 ]
          Jukka Zitting made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Jukka Zitting made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          fabrizio giustina made changes -
          Link This issue incorporates JCR-1694 [ JCR-1694 ]
          Jukka Zitting made changes -
          Workflow jira [ 12420608 ] no-reopen-closed, patch-avail [ 12468564 ]

            People

            • Assignee:
              Jukka Zitting
              Reporter:
              Alexander Klimetschek
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development