[JCR-1302] ArrayHits does not end properly when skipTo doesn't find document

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4
• Component/s: jackrabbit-core, query
• Assignee: Christoph Kiehl
• Reporter: Rob Owen
• Created: 09/Jan/08 21:31
• Updated: 15/Jan/08 23:27
• Resolved: 10/Jan/08 12:23

Description

If skipTo(target) does not find a document that that has a higher value than the target, it falls out of the loop and calls next() possibly returning a previously found document. The patch makes sure that -1 is returned in this case, otherwise confusing results might occur.

Index: src/main/java/org/apache/jackrabbit/core/query/lucene/hits/ArrayHits.java
===================================================================
— src/main/java/org/apache/jackrabbit/core/query/lucene/hits/ArrayHits.java (revision 608900)
+++ src/main/java/org/apache/jackrabbit/core/query/lucene/hits/ArrayHits.java (working copy)
@@ -87,9 +87,9 @@
int nextDocValue = hits[i];
if (nextDocValue >= target)

{ index = i; - break; + return next(); }

}

• return next();
  + return -1;
  }
  }