Uploaded image for project: 'jclouds'
  1. jclouds
  2. JCLOUDS-1334

Guava 23.0 incompatibility: missing SimpleTimeLimiter constructor

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.1.0
    • jclouds-core

    Description

      With Guava 23, the public constructor for SimpleTimeLimiter, which was deprecated in Guava 22.0, has been removed. This constructor is used by JClouds' ExecutorServiceModule and by some tests.

      Tests won't be compiled under Guava 23, so that's not a concern, but anyone running JClouds with Guava 23 will get a runtime error when ExecutorServiceModule is loaded.

      Easiest fix is to use reflection to call SimpleTimeLimiter.create (introduced in Guava 22.0) if possible, and fall back to the constructor otherwise.

      This was noticed after the resolution of JCLOUDS-1225, which brought compatibility to Guava 22.0.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            gaul Andrew Gaul
            tpeierls Tim Peierls
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment