[JCLOUDS-1153] Docker ImageToImage class doesn't support empty repoTags list

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.2
• Fix Version/s: 2.0.0
• Component/s: jclouds-labs
• Labels: docker
• Environment: Docker version 1.12
• Assignee: Unassigned
• Reporter: Josef Cacek
• Created: 11/Aug/16 16:34
• Updated: 30/Aug/16 09:35
• Resolved: 12/Aug/16 07:40

Description

When a Docker image doesn't contain any repoTag, then the `ImageToImage` function fails with

java.lang.IndexOutOfBoundsException: position (1) must be less than the number of elements that remained (1)

So the current implementation of listing Docker images fails when there is an image with empty repoTags field. (E.g. It happens after pulling a new "latest" tag of an image and the original image didn't have any other tags).

IMO the original intention was to throw NPE by this call in the ImageToImage.apply() method:

String description = checkNotNull(Iterables.getFirst(from.repoTags(), "image must have at least one repo tag"));

but it instead sets the description to "image must have at least one repo tag" and it fails later on splitting the value.