[JCLOUDS-1143] AWSv4SignerBase fails to log canonicalRequest

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: jclouds-blobstore
• Assignee: Andrew Gaul
• Reporter: Stephen Tomkinson
• Created: 18/Jul/16 10:10
• Updated: 10/Aug/16 22:09
• Resolved: 19/Jul/16 18:12

Description

The logging of the "canonical request" for AWS v4 signing of S3 requests currently omits the canonical request string itself. The cause appears to be line 403 (https://github.com/apache/jclouds/blob/18cba94fab010152f00396439c3d1a8bfd9d7681/apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerBase.java#L403) which is using a templated logging call, but passes a logging message String without template placeholders.

Elsewhere, String concatenation is used - e.g. https://github.com/apache/jclouds/blob/18cba94fab010152f00396439c3d1a8bfd9d7681/apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerForChunkedUpload.java#L191