[JCLOUDS-1042] S3BlobStore.putBlob() makes a call to get ACL which maybe blocked by S3 policy, resulting in failure of the operation.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9.1
• Fix Version/s: 2.0.0
• Component/s: jclouds-blobstore
• Labels: s3
• Assignee: Andrew Gaul
• Reporter: Igor Alekseev
• Created: 30/Nov/15 20:38
• Updated: 04/Jun/16 04:49
• Resolved: 04/Jun/16 04:49

Description

A user may be prevented by S3 bucket policy from getting ACL, but can still have rights to do put/get/delete. Currently the code below fails to do put when there's an exception getting ACL.

public String putBlob(String container, Blob blob, PutOptions overrides) {
      if (overrides.isMultipart()) {
         // need to use a provider if the strategy object is stateful
         return multipartUploadStrategy.get().execute(container, blob);
      }

      // TODO: Make use of options overrides
      PutObjectOptions options = new PutObjectOptions();
      try {
         AccessControlList acl = bucketAcls.getUnchecked(container);
         if (acl != null && acl.hasPermission(GroupGranteeURI.ALL_USERS, Permission.READ))
            options.withAcl(CannedAccessPolicy.PUBLIC_READ);
      } catch (CacheLoader.InvalidCacheLoadException e) {
         // nulls not permitted from cache loader
      }
      return sync.putObject(container, blob2Object.apply(blob), options);
   }