Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
-
None
-
Operating System: other
Platform: Other
-
36257
Description
1. Using CharArrayReader instead of ByteArrayInputStream: This avoids conversion
of chars to bytes and back (Janino uses a Reader to read from the stream).
2. Providing an implementation of Janino's ErrorHandler and WarningHandler:
Allows to get information than just CompileExceptions.
3. Iterating over the map's entry set instead of its key set: This avoids a
lookup using get(key).
4. Common formatting at least for this file: parameters prefixed with 'p',
references to instance variable prefixed with 'this'. Is there a style guide for
this project?
This patch mixes 4 issues, but each of it has only minor effects, that it is
manageable I think:
1. -2 +2 lines
2. +3 lines inside, + implementation of CompilationProblemHandlerAdapter at the end
3. -4 +3 lines
4. the rest