Uploaded image for project: 'James Server'
  1. James Server
  2. JAMES-609

MailImpl.setMessage and possible NPE: regression from 2.2.0 and 2.3.0rc1

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.3.0
    • Component/s: James Core
    • Labels:
      None

      Description

      The change introduced in rc2 to fix the file leaks has produced an NPE in a custom mailet.

      I suggest to revert the setMessage changes removing the dispose() call for the old message and to put the dispose code in the bundled calling mailets.

      This is not a good fix in the long term, but for 2.3.0 I would prefer to keep compatibility with 2.2.0 and to have a leak instead of NPE (difficult to understand by most users).

        Attachments

        1. JAMES-609.diff
          20 kB
          Stefano Bagnara

          Activity
          $i18n.getText('security.level.explanation', $currentSelection) Viewable by All Users
          Cancel

            People

            • Assignee:
              bago Stefano Bagnara
              Reporter:
              bago Stefano Bagnara

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment