Uploaded image for project: 'James Server'
  1. James Server
  2. JAMES-440

Improve DBCP: provide more DBCP options, like removeAbandoned

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Add more DBCP options, like removeAbandoned.
      By the way, I set it to true by default as I think it help to debug and to make James/JDBC connection more reliable.

      1. JdbcDataSource.java
        13 kB
        Laurent Rouvet

        Activity

        Hide
        bago Stefano Bagnara added a comment -

        I've not included the deprecated properties (no "Abandoned" stuff).
        I don't know why they deprecated them, but they did it and we should not use that properties.

        Show
        bago Stefano Bagnara added a comment - I've not included the deprecated properties (no "Abandoned" stuff). I don't know why they deprecated them, but they did it and we should not use that properties.
        Hide
        rouvet Laurent Rouvet added a comment -

        I didn't find the official reason... (does DBCP have a mail list?)
        However I found several issue about this feature...
        It seems that the implementation is quite bad... see
        http://forum.java.sun.com/thread.jspa?threadID=658047&messageID=3866148

        However, this feature is still very very useful at least to help finding connection leak.
        So, it's definitely something that is needed to debugging.

        I know that it's deprecated but I still propose to keep it with some comment explaining that it should use for debugging only. When you debug, it's easy to active that feature but not so easy to recompile and deploy James when needed.

        What do you find?

        +1

        Also, we may look at fixing that DBCP issue... Does someone like Noel know people of that team?

        Show
        rouvet Laurent Rouvet added a comment - I didn't find the official reason... (does DBCP have a mail list?) However I found several issue about this feature... It seems that the implementation is quite bad... see http://forum.java.sun.com/thread.jspa?threadID=658047&messageID=3866148 However, this feature is still very very useful at least to help finding connection leak. So, it's definitely something that is needed to debugging. I know that it's deprecated but I still propose to keep it with some comment explaining that it should use for debugging only. When you debug, it's easy to active that feature but not so easy to recompile and deploy James when needed. What do you find? +1 Also, we may look at fixing that DBCP issue... Does someone like Noel know people of that team?
        Hide
        danny@apache.org Danny Angus added a comment -

        Closing issue fixed in released version.

        Show
        danny@apache.org Danny Angus added a comment - Closing issue fixed in released version.

          People

          • Assignee:
            bago Stefano Bagnara
            Reporter:
            rouvet Laurent Rouvet
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development