[JAMES-3834] PBKDF2WithHmacSHA1: Use of a broken or risky cryptographic algorithm

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: Blob, UsersStore & UsersRepository
• Labels: security
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 12/Oct/22 05:22
• Updated: 14/Oct/22 03:44
• Resolved: 14/Oct/22 03:44

Description

What?

Cryptographic algorithm `PBKDF2WithHmacSHA1` is weak and should not be used.

Using broken or weak cryptographic algorithms can leave data vulnerable to being decrypted.

Many cryptographic algorithms provided by cryptography libraries are known to be weak, or flawed. Using such an algorithm means that an attacker may be able to easily decrypt the encrypted data.
Recommendation

*Recommendation*

Ensure that you use a strong, modern cryptographic algorithm. Use at least AES-128 or RSA-2048. Do not use the ECB encryption mode since it is vulnerable to replay and other attacks.

(Found via Github code scans...)

Fix

For blob AES :

-> Defaults to usage of PBKDF2WithHmacSHA512
-> Allow people to configure other algorithms, including PBKDF2WithHmacSHA1
-> No migration strategy for people having already encrypted data (stick to PBKDF2WithHmacSHA1)

For user hashing:

-> add a new user password hashing algorithm based on PBKDF2WithHmacSHA512
-> Make it the default one
-> Hashing "on the fly" migration already present...

Issue Links

• links to: GitHub Pull Request #1249