[JAMES-359] remote address from Received header is not handled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.3.0
• Component/s: FetchMail
• Assignee: Unassigned
• Reporter: Stefano Bagnara
• Created: 18/Mar/05 18:50
• Updated: 21/Nov/07 08:31
• Resolved: 08/Aug/05 17:13

Description

Look at this method code:

protected String computeRemoteDomain() throws MessagingException

{ StringBuffer domainBuffer = new StringBuffer(); String[] headers = null; if (getRemoteReceivedHeaderIndex() > -1) getMessageIn().getHeader(RFC2822Headers.RECEIVED); if (null != headers) # DO SOMETHING.... }

// Default is "localhost"
if (domainBuffer.length() == 0)
domainBuffer.append("localhost");

return domainBuffer.toString().trim();
}

You can see that there is a missing assignment to "headers = " before the "getMessageIn().getHeader()" stuff.

Without the assignment this code will never work and the remote address recognition feature is not working ad all.