Uploaded image for project: 'James Server'
  1. James Server
  2. JAMES-359

remote address from Received header is not handled

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.3.0
    • Component/s: FetchMail
    • Labels:
      None

      Description

      Look at this method code:

      protected String computeRemoteDomain() throws MessagingException

      { StringBuffer domainBuffer = new StringBuffer(); String[] headers = null; if (getRemoteReceivedHeaderIndex() > -1) getMessageIn().getHeader(RFC2822Headers.RECEIVED); if (null != headers) # DO SOMETHING.... }

      // Default is "localhost"
      if (domainBuffer.length() == 0)
      domainBuffer.append("localhost");

      return domainBuffer.toString().trim();
      }

      You can see that there is a missing assignment to "headers = " before the "getMessageIn().getHeader()" stuff.

      Without the assignment this code will never work and the remote address recognition feature is not working ad all.

        Activity

        Hide
        bago Stefano Bagnara added a comment -

        I just downloaded the latest SVN revision from "branch_2_1_fcs" and it seems to be fixed.

        Show
        bago Stefano Bagnara added a comment - I just downloaded the latest SVN revision from "branch_2_1_fcs" and it seems to be fixed.
        Hide
        bago Stefano Bagnara added a comment -

        Was already fixed in svn when reported.

        Show
        bago Stefano Bagnara added a comment - Was already fixed in svn when reported.
        Hide
        danny@apache.org Danny Angus added a comment -

        Closing issue fixed in released version.

        Show
        danny@apache.org Danny Angus added a comment - Closing issue fixed in released version.

          People

          • Assignee:
            Unassigned
            Reporter:
            bago Stefano Bagnara
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development