Uploaded image for project: 'James Server'
  1. James Server
  2. JAMES-328

TOP <msg> 0 does not return a terminator on error

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.3.0
    • Component/s: POP3Server
    • Labels:
      None
    • Environment:
      James version 2.2.0 running on redhat 9, java version 1.4.2_03, mysql version 4.0.17 pc-linux-686

      Description

      I first noticed the problem using Java mail version 1.3.1 attempting to retrieve a malformed pop3 message from James. The message headers specify an invalid encoding type "Content-Transfer-Encoding: plain". When the command "TOP <msg> 0" is issued, James returns "+OK Message follows", then successfully returns all headers. Upon attempting to retrieve 0 lines of the message, it apparently encounters an error with that invalid encoding type and returns "-ERR Error while retrieving message." rather then the termination character of carriage return, period, carriage return. Javamail chokes on this waiting for the period termination character as it thinks that the "-ERR" text is a valid part of the message.

      The "RETR" command works properly however and returns the message without error. Looking into the source code for James, I found that even though the argument is to return 0 lines of the message, James still attempts to write the message to the output with the call "mc.writeContentTo(nouts, lines);" lines = 0 in this case and I put in a temporary work around to not do this unless lines was > 0, but if a TOP command was issued with 5 for example, it would still return the invalid response.

      Not sure what the best solution is, but it needs to either return -ERR up front, or to return the termination character regardless so that dumb mail clients can process it.

        Attachments

        1. top.diff
          2 kB
          Hes Siemelink

          Activity

            People

            • Assignee:
              bago Stefano Bagnara
              Reporter:
              jglorioso John Glorioso
            • Votes:
              2 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: