[JAMES-2986] NetMatcher's comma-separation requires space to be present

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: master
• Fix Version/s: 3.5.0
• Component/s: James Core
• Assignee: Unassigned
• Reporter: Jörg Thomas (ConSol)
• Created: 19/Nov/19 16:20
• Updated: 25/Nov/19 12:06
• Resolved: 25/Nov/19 12:06

Description

When for example configuring the RemoteAddrNotInNetwork mailet, you're supposed to "give a comma-delimited list of IP addresses, domain names or sub-nets".

In reality, you're supposed to give that string separated/delimited by [COMMA][SPACE].

Failure to do so will result in ArrayOutOfBoundsExceptions

java.lang.ArrayIndexOutOfBoundsException: 7
   at org.apache.james.dnsservice.library.inetnetwork.InetNetworkBuilder.normalizeV4FromAsterisk(InetNetworkBuilder.java:192)
   at org.apache.james.dnsservice.library.inetnetwork.InetNetworkBuilder.getV4FromString(InetNetworkBuilder.java:127)
   at org.apache.james.dnsservice.library.inetnetwork.InetNetworkBuilder.getFromString(InetNetworkBuilder.java:101)
   at org.apache.james.dnsservice.library.netmatcher.NetMatcher.initInetNetworks(NetMatcher.java:163)
   at org.apache.james.dnsservice.library.netmatcher.NetMatcher.initInetNetworks(NetMatcher.java:146)

Expectation: Handle [COMMA]-only as separator.

Issue Links

• links to: GitHub Pull Request #178