[JAMES-295] Missing sqlDefs wont be detected

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.3.0
• Assignee: Stefano Bagnara
• Reporter: Mark Daring
• Created: 04/Jun/04 22:40
• Updated: 21/Nov/07 08:31
• Resolved: 10/Aug/05 05:43

Description

Starting at line 113 in SQLResources.java
Elements with tagname "sqlDefs" are scanned for the name of the class we want the sql-strings for.
At line 125 if this element isnt found, by assuming "sectionElement==null", an exception is thrown.
So the question is, how can sectionElement be ever null if the "sqlDef" we are looking for isnt in the xml-file?

For your convenience:
" ...
// Now get the section defining sql for the repository required.
113 NodeList sections = sqlDoc.getElementsByTagName("sqlDefs");
114 int sectionsCount = sections.getLength();
Element sectionElement = null;
for (int i = 0; i < sectionsCount; i++ ) {
sectionElement = (Element)(sections.item);
String sectionName = sectionElement.getAttribute("name");
if ( sectionName != null && sectionName.equals(sqlDefsSection) )

{ break; }

}
125 if ( sectionElement == null )

{ StringBuffer exceptionBuffer = new StringBuffer(64) .append("Error loading sql definition file. ") .append("The element named \'") .append(sqlDefsSection) .append("\' does not exist."); throw new RuntimeException(exceptionBuffer.toString()); }

... "