[JAMES-268] Spooler.accept(...) can leave locked messages and leak memory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.2.0
• Component/s: MailStore & MailRepository
• Assignee: Unassigned
• Reporter: Noel J. Bergman
• Created: 22/Apr/04 00:42
• Updated: 05/Jun/04 19:29
• Resolved: 22/Apr/04 01:50

Description

I believe there is a memory leak under an error condition in the spooler that I'll be fixing, but that should be able to wait for a 2.2.1. If I am correct, the nature of the error is here:

if (lock(s)) {
MailImpl mail = null;
try

{ mail = retrieve(s); }

catch (javax.mail.MessagingException e)

{ ... }

if (mail == null)

{ continue; }

If retrieve returns null or throws an exception, the lock is kept, and we leak memory. Also ...

if (filter.accept (mail.getName(),
mail.getState(),
mail.getLastUpdated().getTime(),
mail.getErrorMessage()))

{ return mail; }

If the filter doesn't accept, we leak the lock info, although we'll eventually clean it up. The problem here is that the message is forever locked for this specific thread.