[JAMES-2682] Infinite loop can be triggered upon Sieve failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: master, 3.3.0
• Fix Version/s: 3.4.0
• Component/s: Mailet Contributions
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 12/Mar/19 04:15
• Updated: 26/Mar/19 04:44
• Resolved: 26/Mar/19 04:44

Description

As pointed out by pleira, failing sieve processing can generate an mail infinite loop.

SieveExecutor::handleFailure sends a mail to the user, that is also SIEVE processed (and thus fails) creating a loop.

To prevent this loop, we should avoid Sieve processing on Sieve error notification emails.

In Sieve executor, position a `"SieveNotification" -> true` mail attribute in `SieveExecutor::handleFailure`. In SieveExecutor::execute check this mail attribute and if present and true, do not perform the execution. You will write a unit test in SieveIntegrationTest - Emails with this attribute should not be processed.

If you have any issue don't hesitate to reach us in https://gitter.im/apache/james-project