[JAMES-2282] Some Cassandra DAOs are not bound in Singleton scope

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: master
• Component/s: cassandra, guice
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 09/Jan/18 04:10
• Updated: 26/Jan/18 12:42
• Resolved: 26/Jan/18 12:42

Description

We encounter some log lines like:

Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='UPDATE mailboxCounters SET unseen=unseen-1 WHERE mailboxId=:mailboxId;'
Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='UPDATE mailboxCounters SET count=count-1 WHERE mailboxId=:mailboxId;'
Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='UPDATE mailboxCounters SET unseen=unseen+1 WHERE mailboxId=:mailboxId;'
Re-preparing already prepared query is generally an anti-pattern and will likely affect performance. Consider preparing the statement only once. Query='INSERT INTO mailbox (id,name,uidvalidity,mailboxbase) VALUES (:id,:name,:uidvalidity,:mailboxbase);'

These DAOs are created every time they are injected by Guice, which leads to re-preparing queries.

We should rather bind them in scope singleton.