[JAMES-2163] Passing null parameters to Mail seems possible

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: master
• Fix Version/s: master
• Component/s: James Core
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 28/Sep/17 02:25
• Updated: 29/Jan/18 03:41
• Resolved: 29/Jan/18 03:41

Description

As reported by @arpitsriv on Gitter, it seems possible to write an email with possibly null parameters.

This causes defacts later on, for instance in his case when enqueing the email.

We need upfront null value rejection on the MailImpl object, via Preconditions. This will bring the error closer to the code causing the defect, and makes debugging easier.

Unit tests should be provided on the MailImpl object.

Thanks to @arpitsriv for his time spotting and understanding this issue.