Uploaded image for project: 'James Server'
  1. James Server
  2. JAMES-1808

if (character > 128) should be changed to if (character >= 128)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0-beta5
    • Fix Version/s: 3.0.0
    • Component/s: IMAPServer
    • Labels:
      None

      Description

      There is a conditional code block as follows in the class 'ImapResponseComposerImpl' of the package 'org.apache.james.imap.encode.base' in the 'protocols-imap' project.
      // 7-bit ASCII only
      if (character > 128)

      { buffer.write(BYTE_QUESTION); }

      else

      { buffer.write((byte) character); }

      An equals(=) sign should be included in the conditional since the range of US-ASCII is from 0 to 127(not including 128).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              leepaul21 Paul Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: