[JAMES-1494] org.apache.james.smtpserver.CoreCmdHandlerLoader does not register org.apache.james.protocols.smtp.core.UnknownCmdHandler

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 3.0.0-beta5
• Component/s: SMTPServer
• Assignee: Eric Charles
• Reporter: Andrzej Rusin
• Created: 22/Mar/13 19:29
• Updated: 14/Apr/13 13:46
• Resolved: 14/Apr/13 13:46

Description

It results in unknown commands getting message:

451 Unable to process request

and NPE:

DEBUG 15:07:23,602 | james.smtpserver | Id='1219837423' User='' org.apache.james.protocols.api.handler.CommandDispatcher received: SA
DEBUG 15:07:23,602 | james.smtpserver | Id='1219837423' User='' Lookup command handler for command: SA
DEBUG 15:07:23,603 | james.smtpserver | Id='1219837423' User='' Unable to parse request
java.lang.NullPointerException
at org.apache.james.protocols.api.handler.CommandDispatcher.dispatchCommandHandlers(CommandDispatcher.java:170)
at org.apache.james.protocols.api.handler.CommandDispatcher.onLine(CommandDispatcher.java:147)
at org.apache.james.protocols.netty.BasicChannelUpstreamHandler.messageReceived(BasicChannelUpstreamHandler.java:147)
at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:75)
at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:558)
at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:777)
at org.jboss.netty.channel.SimpleChannelUpstreamHandler.messageReceived(SimpleChannelUpstreamHandler.java:129)
at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:75)
at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:558)
at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:777)
at org.jboss.netty.handler.execution.ChannelUpstreamEventRunnable.run(ChannelUpstreamEventRunnable.java:44)
at org.jboss.netty.handler.execution.OrderedMemoryAwareThreadPoolExecutor$ChildExecutor.run(OrderedMemoryAwareThreadPoolExecutor.java:312)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:722)

and addtionally, the UnknownHooks do not fire, hence org.apache.james.protocols.smtp.core.fastfail.MaxUnknownCmdHandler has no chance to work.

Issue Links

• is related to: JAMES-1427 DoS scenario(s) in SMTP server