Uploaded image for project: 'IvyDE'
  1. IvyDE
  2. IVYDE-49

Improve the logic of determining docs&sources artifact

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • None
    • None
    • classpath container
    • None

    Description

      Now IvyDE automatically attaches javadoc and sources to artifact if they have the same name.
      That's because IvyClasspathContainer.getSourcesArtifact and IvyClasspathContainer.getJavadocArtifact both use the same logic:
      for(Iterator iter = all.iterator(); iter.hasNext()

      { Artifact a = (Artifact)iter.next(); if(a.getName().equals(artifact.getName()) && ..... <other conditions> return _ivy.getArchiveFileInCache(_ivy.getDefaultCache(), a); }

      In absence of any other means to set relationship between artifacts in Ivy repository file, I suggest to slightly modify this logic to smth like this:
      if( (a.getName().equals(artifact.getName() ) || (a.getName.startsWith(artifact.getName) && a.getName().endsWith(a.getType())) )

      In other words:
      Artifact is considered a javadoc/source for a given jar-artifact, if it starts with the jar name and ends on "doc", or "source".

      It seems rather simple and selective criteria and conforms to the way most javadoc/source archives are currently named.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            sdt78 Stanislav Tsybyshev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment