[IVYDE-209] conf attributes must not be null

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.0
• Component/s: classpath container

Environment

Windows, Eclipse 3.4 with default WTP, RSA 7.5.3

• Assignee: Nicolas Lalevée
• Reporter: Ivica Loncar
• Created: 04/Oct/09 11:03
• Updated: 13/Oct/09 09:55
• Resolved: 13/Oct/09 09:55

Description

With revision 815394 comes a change in IvydeContainerPage from:

IClasspathAttribute[] atts = IvyClasspathContainerConfAdapter.getAttributes(conf);

to

IClasspathAttribute[] atts = conf.getAttributes();

Unfortunately it causes NPE when exporting Dynamic web project in RSA 7.5.3 and older WTP plugins (that comes with 3.4.x bundle).
Sorry, I don't have stacktrace at the moment.

I have fixed it in our build by adding

        IClasspathAttribute[] atts = conf.getAttributes();
        // ILX: atts must not be null
        if (atts == null) {
            atts = new ClasspathAttribute[0];
        }

but I guess this shouldn't be neccessary if IvyClasspathContainerConfiguration returns zero length array instead of null.
I propose to fix IvyClasspathContainerConfiguration by initializing member attributes to an empty array and making sure it never gets initialized to null.