Ivy
  1. Ivy
  2. IVY-871

test and document PatternVersionMatcher

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0-RC2
    • Component/s: Core
    • Labels:
      None

      Description

      There is a powerful version matcher in Ivy code base called PatternVersionMatcher. Unfortunately, this matcher is not documented, not tested, and not declared in the default typedef.properties. Nobody remembers where it comes from, but code analysis should be enough to understand how it works and what it can achieve.

      Here's what I understand from a quick analysis:

      settings.xml
      <pattern-vm>
        <match revision="micro" pattern="${major}\.${minor}\.\d+" args="major, minor" matcher="regexp" />
      </pattern-vm>
      
      ivy.xml
      <dependency org="acme" name="foo" rev="micro(1, 3)" />
      

      If I understand correctly the code, this will match any revision like 1.3.<any number>.

      1. patch.txt
        7 kB
        Jon Schneider

        Activity

        Xavier Hanin created issue -
        Hide
        Jon Schneider added a comment -

        Documentation and test case attached. Let me know if there are any problems with the patch formatting.

        Thanks,
        Jon

        Show
        Jon Schneider added a comment - Documentation and test case attached. Let me know if there are any problems with the patch formatting. Thanks, Jon
        Jon Schneider made changes -
        Field Original Value New Value
        Attachment patch.txt [ 12411644 ]
        Hide
        Maarten Coene added a comment -

        I've applied your patch. Thanks a lot for the contribution.
        Maarten

        Show
        Maarten Coene added a comment - I've applied your patch. Thanks a lot for the contribution. Maarten
        Maarten Coene made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Maarten Coene [ maartenc ]
        Fix Version/s trunk [ 12313426 ]
        Resolution Fixed [ 1 ]
        Maarten Coene made changes -
        Fix Version/s 2.1.0-RC2 [ 12314062 ]
        Fix Version/s trunk [ 12313426 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        330d 42m 1 Maarten Coene 30/Jun/09 21:03

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Xavier Hanin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development