Ivy
  1. Ivy
  2. IVY-483

Tool support for checking code

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      You should use tools like Checkstyle, PMD and Findbugs for checking the code for possible errors.

      1. patch.zip
        9 kB
        Jan Matèrne

        Activity

        Hide
        Jan Matèrne added a comment -

        Patch-Zip-File with files based on Ant's checks ...

        check.xml

        • Ant buildfile starting the Checks.
        • Requires: Checkstyle, Xalan, Simian
        • property "check.tools.dir" must point to a directory containing
          • Checkstyle: checkstyle-all-4.3.jar
          • Simian: simian-2.2.17.jar
          • Xalan (2.7.0): xalan.jar, serializer.jar

        checkstyle-config

        • Configuration file for Checkstyle, activates Checkstyle-Simian addin
        • need customization for Ivy

        checkstyle-*.xsl

        • XSLTs for generating HTML, Text and XDoc files from raw xml (same as in Ant)

        RequiredHeader.txt

        • ASF2.0 license header which must at the beginning of ASF Java files (same as in Ant)
        Show
        Jan Matèrne added a comment - Patch-Zip-File with files based on Ant's checks ... check.xml Ant buildfile starting the Checks. Requires: Checkstyle, Xalan, Simian property "check.tools.dir" must point to a directory containing Checkstyle: checkstyle-all-4.3.jar Simian: simian-2.2.17.jar Xalan (2.7.0): xalan.jar, serializer.jar checkstyle-config Configuration file for Checkstyle, activates Checkstyle-Simian addin need customization for Ivy checkstyle-*.xsl XSLTs for generating HTML, Text and XDoc files from raw xml (same as in Ant) RequiredHeader.txt ASF2.0 license header which must at the beginning of ASF Java files (same as in Ant)
        Hide
        Xavier Hanin added a comment -

        Thanks a lot for this contribution! For the required jars, I suggest we use a little tool called Ivy to download them automatically

        Show
        Xavier Hanin added a comment - Thanks a lot for this contribution! For the required jars, I suggest we use a little tool called Ivy to download them automatically
        Hide
        Maarten Coene added a comment -

        I've integrated your patch (modified it a bit here and there).
        I'm not closing it yet because we need to review the checkstyle configuration

        Show
        Maarten Coene added a comment - I've integrated your patch (modified it a bit here and there). I'm not closing it yet because we need to review the checkstyle configuration
        Hide
        Jan Matèrne added a comment -

        Sure - the patch was intended to be modified. But its less work to modify than to implement a complete new one

        And it's cool to the how Ivy deals with the <taskdef> ...

        <ivy:cachepath
        organisation="checkstyle" module="checkstyle" revision="4.3"
        inline="true" conf="default"
        pathid="checkstyle.classpath" transitive="true"
        />
        <taskdef resource="checkstyletask.properties" classpathref="checkstyle.classpath" />

        Do you have seen the TODO statement in the configuration file? Maybe you want to load Simian too ....

        Show
        Jan Matèrne added a comment - Sure - the patch was intended to be modified. But its less work to modify than to implement a complete new one And it's cool to the how Ivy deals with the <taskdef> ... <ivy:cachepath organisation="checkstyle" module="checkstyle" revision="4.3" inline="true" conf="default" pathid="checkstyle.classpath" transitive="true" /> <taskdef resource="checkstyletask.properties" classpathref="checkstyle.classpath" /> Do you have seen the TODO statement in the configuration file? Maybe you want to load Simian too ....

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Jan Matèrne
          • Votes:
            2 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development