Uploaded image for project: 'Ivy'
  1. Ivy
  2. IVY-239

value of confmappingoverride from imported configurations is lost when writing Ivy file

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.4-RC1
    • Component/s: None
    • Labels:
      None

      Description

      If you import an external configurations-file which specifies the value of the confmappingoverride attribute, this value doesn't appear in the Ivy file produced by the the deliver task.

      The problem is in the XmlModuleDescriptorUpdater class.
      I don't see an easy way to do this in a clean way, except if we also support this attribute on the dependencies element (like the defaultconfmapping attribute).
      What do you think?

        Activity

        Hide
        xavier Xavier Hanin added a comment -

        I've included your patch, it should be ok now. Thanks for your contribution.

        Show
        xavier Xavier Hanin added a comment - I've included your patch, it should be ok now. Thanks for your contribution.
        Hide
        maartenc Maarten Coene added a comment -

        Required resource for the junit test

        Show
        maartenc Maarten Coene added a comment - Required resource for the junit test
        Hide
        maartenc Maarten Coene added a comment -

        Required resource for the junit test.

        Show
        maartenc Maarten Coene added a comment - Required resource for the junit test.
        Hide
        maartenc Maarten Coene added a comment -

        Please ignore the change to Ivy.java in the previous patch.
        The other changes in the uploaded patch are still valid though!

        Show
        maartenc Maarten Coene added a comment - Please ignore the change to Ivy.java in the previous patch. The other changes in the uploaded patch are still valid though!
        Hide
        maartenc Maarten Coene added a comment -

        This patch bundles the previous patches, includes a junit test and some other changes to XmlModuleDescriptorParser to make the testing easier.

        Show
        maartenc Maarten Coene added a comment - This patch bundles the previous patches, includes a junit test and some other changes to XmlModuleDescriptorParser to make the testing easier.
        Hide
        maartenc Maarten Coene added a comment -

        Patch for ivy.xsd to allow the confmappingoverride attribute to appear on the dependencies element.

        Show
        maartenc Maarten Coene added a comment - Patch for ivy.xsd to allow the confmappingoverride attribute to appear on the dependencies element.
        Hide
        maartenc Maarten Coene added a comment -

        Xavier,
        will this be included in the 1.4 release as well?

        Show
        maartenc Maarten Coene added a comment - Xavier, will this be included in the 1.4 release as well?
        Hide
        xavier Xavier Hanin added a comment -

        Yes! sorry for the mistake.

        Show
        xavier Xavier Hanin added a comment - Yes! sorry for the mistake.
        Hide
        maartenc Maarten Coene added a comment -

        I'll try to upload a junit test later (not sure if I'll have the time to create one)
        However, I've tested the patch manually and it seems to work

        regards,
        Maarten

        Show
        maartenc Maarten Coene added a comment - I'll try to upload a junit test later (not sure if I'll have the time to create one) However, I've tested the patch manually and it seems to work regards, Maarten
        Hide
        maartenc Maarten Coene added a comment -

        Patch for XmlModuleDescriptorUpdater.java

        Show
        maartenc Maarten Coene added a comment - Patch for XmlModuleDescriptorUpdater.java
        Hide
        maartenc Maarten Coene added a comment -

        Patch for XmlModuleDescriptorParser.java

        Show
        maartenc Maarten Coene added a comment - Patch for XmlModuleDescriptorParser.java
        Hide
        xavier Xavier Hanin added a comment -

        adding it on the dependency element seems to be a not too bad idea (not really elegant, but at least it's consistent with defaultconfmapping ).

        Show
        xavier Xavier Hanin added a comment - adding it on the dependency element seems to be a not too bad idea (not really elegant, but at least it's consistent with defaultconfmapping ).

          People

          • Assignee:
            xavier Xavier Hanin
            Reporter:
            maartenc Maarten Coene
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Development