Uploaded image for project: 'Ivy'
  1. Ivy
  2. IVY-1609

Removal of WARN deprecation when not valid

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 2.5.0-rc1
    • None
    • Core

    Description

      "WARN: symlinkmass option has been deprecated and will no longer be supported" gets fed back as a problem message, even when this option is not set.

      I noticed this when trying to get integration to work with embedding ivy. The program which utilizes ivy checks ResolveReport.getAllProblemMessages() after a resolve/retrieve is done.
      It assumes something did not go correctly.

      I don't think its appropriate to send this back in getAllProblemMessages when the symlinkmass is not set.
      This could be fixed simply by testing if symlinkmass is being set to true in the option

      RetrieveOptions.java line 184
      https://github.com/apache/ant-ivy/blob/master/src/java/org/apache/ivy/core/retrieve/RetrieveOptions.java#L183-L188

      @Deprecated
      public RetrieveOptions setMakeSymlinksInMass(boolean makeSymlinksInMass) {
      this.makeSymlinksInMass = makeSymlinksInMass;
      if (makeSymlinksInMass) {
      Message.warn("symlinkmass option has been deprecated and will no longer be supported");
      }
      return this;
      }

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jaikiran Jaikiran Pai
            grog Greg Perry

            Dates

              Created:
              Updated:

              Slack

                Issue deployment