[IVY-1517] ivy resolve haltonfailure is not checked in all cases

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.4.0
• Component/s: Core
• Assignee: Unassigned
• Reporter: Jan Materne
• Created: 26/Mar/15 13:19
• Updated: 26/Mar/15 13:19

Description

Moved from Bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57763

Tested with ant version 1.9.4, ivy version 2.4.0 on Windows 7.

I call ivy:resolve from my build.xml specifying haltonfailure="false".

<ivy:resolve conf="*" file="ivy.xml" haltonfailure="false"/>

There are conflicts in ivy.xml and the build is stopped, haltonfailure is ignored.

I checked in the source code what happened.

StrictConflictManager.resolveConflicts() throws StrictConflictException.
The exception is catched in ResolveEngine.resolve(ModuleDescriptor md, ResolveOptions options) as a RuntimeException and is re-thrown.
Then it's catched again in IvyResolve.doExecute().

The following code in IvyResolve.doExecute()

if (report.hasError()) {
if (failureProperty != null)

{ getProject().setProperty(failureProperty, "true"); }

if (isHaltonfailure())

{ throw new BuildException("resolve failed - see output for details"); }

}

which suppose to check haltonfailure property is never called.