[IVY-1282] XmlModuleDescriptorParser seems to lack some trim() calls

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.5.0-rc1
• Component/s: Core
• Labels: testcase
• Assignee: Gintas Grigelionis
• Reporter: Björn Kautler
• Created: 04/Apr/11 16:26
• Updated: 15/Mar/18 21:50
• Resolved: 15/Mar/18 21:50

Description

The XmlModuleDescriptorParser or whatever seems to miss some trim() calls. The "conf" attribute of the "dependency" tag is heavily spaces-dependent. I will attach a build.xml and an ivy.xml that can be used to test the issue. Here the different cases I tested:

expected result if confmappingoverride="true":

• sources mapped to sources
• compile mapped to master
• runtime mapped to default

lib/:
compile ivy runtime sources

lib/compile:
slf4j-log4j12.jar

lib/ivy:
ivy-2.2.0.jar

lib/runtime:
log4j.jar slf4j-api.jar slf4j-log4j12.jar

lib/sources:
slf4j-log4j12-sources.jar

actual result:

conf="compile;sources" -> like expected
conf=" compile;sources" -> like expected
conf="compile ;sources" -> like expected
conf="compile; sources" -> sources mapped to default
conf="sources; compile" -> like expected
conf="compile ; sources" -> sources mapped to default
conf="compile,sources" -> runtime mapped to master
conf="compile ,sources" -> like expected
conf="compile , sources" -> sources mapped to default
conf="compile, sources" -> sources mapped to default; runtime mapped to master

expected result if confmappingoverride="false":

• sources mapped to sources
• compile mapped to master
• runtime mapped to master

lib/:
compile ivy runtime sources

lib/compile:
slf4j-log4j12.jar

lib/ivy:
ivy-2.2.0.jar

lib/runtime:
slf4j-log4j12.jar

lib/sources:
slf4j-log4j12-sources.jar

actual result:

conf="compile;sources" -> like expected
conf=" compile;sources" -> runtime mapped to default
conf="compile ;sources" -> runtime mapped to default
conf="compile; sources" -> sources mapped to default
conf="sources; compile" -> runtime mapped to default
conf="compile ; sources" -> sources mapped to default; runtime mapped to default
conf="compile,sources" -> like expected
conf="compile ,sources" -> runtime mapped to default
conf="compile , sources" -> sources mapped to default; runtime mapped to default
conf="compile, sources" -> sources mapped to default

Issue Links

• is related to: IVY-309 Use an abstraction of configurations