Ivy
  1. Ivy
  2. IVY-1085

Retrieve ant task doesn't support dynamic resolve mode

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.x, 2.3.0-RC1
    • Fix Version/s: 2.1.0-RC2
    • Component/s: Ant
    • Labels:
      None

      Description

      let's have modules A, B and C. A depends on B which depends on C.
      I have following versions released :

      • A - none, depends on B : 0.0.+
      • B - 0.0.1 , depends on C : 0.0.+, released with C rev=0.0.1,
      • C - 0.0.1 and 0.0.2

      In order to always use freshest released version matching constraints I tried to use resolveMode="dynamic" in resolve task. This worked for resolve (report shows correct dependency choosen (C:0.0.2). However retrieve happily ignores it and downloads 0.0.1. I'm resolving with resolveId and retrieving with the same resolveId.

      I tracked this a little bit.
      Inside IvyPostResolveTask there is prepareAndCheck method. It does some magic which gets down to that ivy in most scenarios (when retrieval is not inline for known module and organisation) does a second resolve inside retrieve to get configurations for retrieval. This is done in ensureResolve method:

           protected void ensureResolved(IvySettings settings) {
              String requestedConfigs = getProperty(getConf(), settings, "ivy.resolved.configurations");
                  
              String[] confs = null;
              if (getResolveId() != null) {
                  confs = getConfsToResolve(getResolveId(), requestedConfigs);
              } else {
                  confs = getConfsToResolve(getOrganisation(), getModule(), requestedConfigs, false);
              }
                  
              if (confs.length > 0) {
                  IvyResolve resolve = createResolve(isHaltonfailure(), isUseOrigin());
                  resolve.setFile(getFile());
                  resolve.setTransitive(isTransitive());
                  resolve.setConf(StringUtils.join(confs, ", "));
                  resolve.setResolveId(getResolveId());
                  resolve.execute();
              }
          }
      

      First - could someone please rationalise this resolve inside retrieve ?
      Second - this resolve happily ignores whatever resolveMode I did set previously.

      The workaround I did was to extend IvyPostResolveTask with resolveMode parameter and put it explicitly in to the ant config, but maybe there is a better solution ?

      If the above is accepted I can produce a patch against trunk and post it here.

        Activity

        Hide
        Maarten Coene added a comment -

        I've added an "resolveMode" attribute to the IvyPostResolveTask (like you already did yourself).

        Thanks for reporting.
        Maarten

        Show
        Maarten Coene added a comment - I've added an "resolveMode" attribute to the IvyPostResolveTask (like you already did yourself). Thanks for reporting. Maarten

          People

          • Assignee:
            Maarten Coene
            Reporter:
            Jarosław Wypychowski
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development