Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-993

Show different object members on multiple tabs

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: viewer-wicket-1.7.0
    • Fix Version/s: 1.12.0
    • Component/s: Core, Core: Viewer: Wicket
    • Labels:
      None

      Description

      4-jan-2016:
      Divide the screen into two halves.

      All properties in separate tabs.

      Each collection in its own tabs.

      ~~~
      as per [1] mailing list thread.

      The example in the mailng list splits up the object's properties/collections (contributed or otherwise) into two different sets of tabs... but as a first pass I think a single row of tabs ought to suffice.

      We also need to be mindful that we may want to use tabs as a metaphor for multiple opened objects (as a replacement for bookmarks), so this is another reason for a single row of tabs.

      To support this would require extensions to @DomainObjectLayout or equivalent xxx.layout.json file.

      [1] http://markmail.org/message/merftvqoiy6ht3kq

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6fa0376873749031bd64b3a34201742b49e6ffa4 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6fa0376 ]

          ISIS-993: SizeSpan (one of the grid classes) should be serializable.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6fa0376873749031bd64b3a34201742b49e6ffa4 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6fa0376 ] ISIS-993 : SizeSpan (one of the grid classes) should be serializable.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 981d731f3642ccbe67c3a8c78c677c1bf1794a4f in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=981d731 ]

          ISIS-1299: JAXB-annotated view models are now edited.

          I suspect that ISIS-993 also had broken other directly cloneable view models; anyway, is now fixed.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 981d731f3642ccbe67c3a8c78c677c1bf1794a4f in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=981d731 ] ISIS-1299 : JAXB-annotated view models are now edited. I suspect that ISIS-993 also had broken other directly cloneable view models; anyway, is now fixed.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1cfb478e022502f0f7ea26dca87bae8094ce5bb6 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1cfb478 ]

          ISIS-993: fixing the JDK7 re-implementation (which was resulting in spurious top-level actions appearing as top-level)

          For some reason FluentIterable#transform(...) doesn't iterate as I expected. Replacing with a simple loop.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1cfb478e022502f0f7ea26dca87bae8094ce5bb6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1cfb478 ] ISIS-993 : fixing the JDK7 re-implementation (which was resulting in spurious top-level actions appearing as top-level) For some reason FluentIterable#transform(...) doesn't iterate as I expected. Replacing with a simple loop.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit cf14cead09f73fb3cca051be1fa99427ffb9b2e1 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cf14cea ]

          ISIS-993: domain object facets (from grid XML) should overwrite existing facets in metamodel (if present)

          ... eg bookmarking, naming

          Show
          jira-bot ASF subversion and git services added a comment - Commit cf14cead09f73fb3cca051be1fa99427ffb9b2e1 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cf14cea ] ISIS-993 : domain object facets (from grid XML) should overwrite existing facets in metamodel (if present) ... eg bookmarking, naming
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 641ae1508463dedb7088a2166eeaf9d87cfddb67 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=641ae15 ]

          ISIS-993: recreating simpleapp archetype

          Show
          jira-bot ASF subversion and git services added a comment - Commit 641ae1508463dedb7088a2166eeaf9d87cfddb67 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=641ae15 ] ISIS-993 : recreating simpleapp archetype
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7805795ba9b87101e7440608514e7050e2ac41fc in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7805795 ]

          ISIS-993: fixing layout in simpleapp; minor doc change

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7805795ba9b87101e7440608514e7050e2ac41fc in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7805795 ] ISIS-993 : fixing layout in simpleapp; minor doc change
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5e0dc0d058702be2cfaee921ae84d939e639613c in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5e0dc0d ]

          ISIS-993: more docs

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5e0dc0d058702be2cfaee921ae84d939e639613c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5e0dc0d ] ISIS-993 : more docs
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d57b100245e7e39a5da0d03d393d1d9f66e46788 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d57b100 ]

          ISIS-993: fixing java7 compile issues.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d57b100245e7e39a5da0d03d393d1d9f66e46788 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d57b100 ] ISIS-993 : fixing java7 compile issues.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3b5da6bd73bbd8e1b62670b5bfaebb9e9af87583 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b5da6b ]

          ISIS-993: fixing compile issue from stale javadoc ref.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3b5da6bd73bbd8e1b62670b5bfaebb9e9af87583 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b5da6b ] ISIS-993 : fixing compile issue from stale javadoc ref.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 41a534db984440b3a163a1285e9f397271ecdf8c in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=41a534d ]

          ISIS-993: more documentation, some minor fixes...

          fixes:

          • if first property in a fieldset is invalid (was losing the actions associated with the fieldset).
          • schema location in downloaded XML was missing the bootstrap3 grid.
          Show
          jira-bot ASF subversion and git services added a comment - Commit 41a534db984440b3a163a1285e9f397271ecdf8c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=41a534d ] ISIS-993 : more documentation, some minor fixes... fixes: if first property in a fieldset is invalid (was losing the actions associated with the fieldset). schema location in downloaded XML was missing the bootstrap3 grid.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9194e136aad5f944374252e411d61b91e12ad41a in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9194e13 ]

          ISIS-993: more documentation.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9194e136aad5f944374252e411d61b91e12ad41a in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9194e13 ] ISIS-993 : more documentation.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3b3daa24bf4c67f096fdcc9e6ea6c385ac7d5255 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b3daa2 ]

          ISIS-993: further documentation on the layout/grid system.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3b3daa24bf4c67f096fdcc9e6ea6c385ac7d5255 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b3daa2 ] ISIS-993 : further documentation on the layout/grid system.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5306b01129faa34e4aef03a1c115db3d801e78e5 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5306b01 ]

          ISIS-993: split LayoutService back out into LayoutService (API) vs GridService (SPI); rationalizing APIs; adding documentation.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5306b01129faa34e4aef03a1c115db3d801e78e5 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5306b01 ] ISIS-993 : split LayoutService back out into LayoutService (API) vs GridService (SPI); rationalizing APIs; adding documentation.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d57b100245e7e39a5da0d03d393d1d9f66e46788 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d57b100 ]

          ISIS-993: fixing java7 compile issues.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d57b100245e7e39a5da0d03d393d1d9f66e46788 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d57b100 ] ISIS-993 : fixing java7 compile issues.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3b5da6bd73bbd8e1b62670b5bfaebb9e9af87583 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b5da6b ]

          ISIS-993: fixing compile issue from stale javadoc ref.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3b5da6bd73bbd8e1b62670b5bfaebb9e9af87583 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b5da6b ] ISIS-993 : fixing compile issue from stale javadoc ref.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 41a534db984440b3a163a1285e9f397271ecdf8c in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=41a534d ]

          ISIS-993: more documentation, some minor fixes...

          fixes:

          • if first property in a fieldset is invalid (was losing the actions associated with the fieldset).
          • schema location in downloaded XML was missing the bootstrap3 grid.
          Show
          jira-bot ASF subversion and git services added a comment - Commit 41a534db984440b3a163a1285e9f397271ecdf8c in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=41a534d ] ISIS-993 : more documentation, some minor fixes... fixes: if first property in a fieldset is invalid (was losing the actions associated with the fieldset). schema location in downloaded XML was missing the bootstrap3 grid.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9194e136aad5f944374252e411d61b91e12ad41a in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9194e13 ]

          ISIS-993: more documentation.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9194e136aad5f944374252e411d61b91e12ad41a in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9194e13 ] ISIS-993 : more documentation.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3b3daa24bf4c67f096fdcc9e6ea6c385ac7d5255 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b3daa2 ]

          ISIS-993: further documentation on the layout/grid system.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3b3daa24bf4c67f096fdcc9e6ea6c385ac7d5255 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3b3daa2 ] ISIS-993 : further documentation on the layout/grid system.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5306b01129faa34e4aef03a1c115db3d801e78e5 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5306b01 ]

          ISIS-993: split LayoutService back out into LayoutService (API) vs GridService (SPI); rationalizing APIs; adding documentation.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5306b01129faa34e4aef03a1c115db3d801e78e5 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5306b01 ] ISIS-993 : split LayoutService back out into LayoutService (API) vs GridService (SPI); rationalizing APIs; adding documentation.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b985845296125bb737df20a55723a10c5ca69ccb in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b985845 ]

          ISIS-993: tidying up GridImplementationService...

          specifically:

          • change lexical order of methods in GridImplementationServiceAbstract, per call hierarchy
          • only generate a warning if in prototyping mode;

          also:

          • if obtaining the complete(...) or the minimal(...) grids, then instantiate a new grid (rather than using the one that might be being cached by GridFacetDefault) because these methods modify said grid object (complete(...) adds stuff, minimal(...) removes stuff).
          Show
          jira-bot ASF subversion and git services added a comment - Commit b985845296125bb737df20a55723a10c5ca69ccb in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b985845 ] ISIS-993 : tidying up GridImplementationService... specifically: change lexical order of methods in GridImplementationServiceAbstract, per call hierarchy only generate a warning if in prototyping mode; also: if obtaining the complete(...) or the minimal(...) grids, then instantiate a new grid (rather than using the one that might be being cached by GridFacetDefault) because these methods modify said grid object (complete(...) adds stuff, minimal(...) removes stuff).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e55640e2645437ab961a9b873eb159cad7d8fc14 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e55640e ]

          ISIS-993: rationalizing and simplifying the domain services that support the dynamic layouts.

          Specifically:

          • new LayoutServiceMenu (formally was MetadataMenu), now delegates to ...
          • renamed GridService to LayoutService, simplified and combined methods, but also added downloadLayouts for LayoutServiceMenu to call
          • renamed GridNormalizerService to GridImplementationService
          Show
          jira-bot ASF subversion and git services added a comment - Commit e55640e2645437ab961a9b873eb159cad7d8fc14 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e55640e ] ISIS-993 : rationalizing and simplifying the domain services that support the dynamic layouts. Specifically: new LayoutServiceMenu (formally was MetadataMenu), now delegates to ... renamed GridService to LayoutService, simplified and combined methods, but also added downloadLayouts for LayoutServiceMenu to call renamed GridNormalizerService to GridImplementationService
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fa4c9c1f71766e31171935dc40c0f528359bd09b in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa4c9c1 ]

          ISIS-993: documentation on XML layouts.

          Show
          jira-bot ASF subversion and git services added a comment - Commit fa4c9c1f71766e31171935dc40c0f528359bd09b in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa4c9c1 ] ISIS-993 : documentation on XML layouts.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4f3932d3894aee180910d5bad24514fcc7bd3673 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4f3932d ]

          ISIS-993: updating the components.xsd in docs directory

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4f3932d3894aee180910d5bad24514fcc7bd3673 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4f3932d ] ISIS-993 : updating the components.xsd in docs directory
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ff4d3427b501b37ee0a36ac3f69d67f39fa79526 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ff4d342 ]

          ISIS-993: extending grid structure to include offsets and allow multiple col-XX-nn to be defined per column.

          Also tidied up the simpleapp:

          • removed .layout.json for HomePageViewModel, replaced with a .layout.xml
          • cleaned up SimpleObject (removing those test collections)
          • removed SimpleObject#updateName action.
          Show
          jira-bot ASF subversion and git services added a comment - Commit ff4d3427b501b37ee0a36ac3f69d67f39fa79526 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ff4d342 ] ISIS-993 : extending grid structure to include offsets and allow multiple col-XX-nn to be defined per column. Also tidied up the simpleapp: removed .layout.json for HomePageViewModel, replaced with a .layout.xml cleaned up SimpleObject (removing those test collections) removed SimpleObject#updateName action.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f763fce110a8bc40c49e5d38fd9b5f63aa4aaf0e in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f763fce ]

          ISIS-993: updating javadoc is all.

          Show
          jira-bot ASF subversion and git services added a comment - Commit f763fce110a8bc40c49e5d38fd9b5f63aa4aaf0e in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f763fce ] ISIS-993 : updating javadoc is all.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2c960ca9eb20756a92d6fe9f77b4c22dc507c267 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c960ca ]

          ISIS-993: removing the ability to view the Grid as a view model (in its own right); no real use case for this functionality at the moment.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2c960ca9eb20756a92d6fe9f77b4c22dc507c267 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c960ca ] ISIS-993 : removing the ability to view the Grid as a view model (in its own right); no real use case for this functionality at the moment.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 393312e4a52a914bfd32d595925b22c700c37187 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=393312e ]

          ISIS-993: fixing unit test from refactoring of SpecificationCacheDefault earlier

          Show
          jira-bot ASF subversion and git services added a comment - Commit 393312e4a52a914bfd32d595925b22c700c37187 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=393312e ] ISIS-993 : fixing unit test from refactoring of SpecificationCacheDefault earlier
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7628fc9d309c8a58ca9f9bbe1e29fa5c5cc044e6 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7628fc9 ]

          ISIS-993: ensure columns in tables are rendered in correct order (require eagerly obtaining grid); also when rendering, ignore any invalid properties/collections/actions.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7628fc9d309c8a58ca9f9bbe1e29fa5c5cc044e6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7628fc9 ] ISIS-993 : ensure columns in tables are rendered in correct order (require eagerly obtaining grid); also when rendering, ignore any invalid properties/collections/actions.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2c62912527240861e2d26bbfac470f06dde70111 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c62912 ]

          ISIS-993: only include entities and view models' layouts in zip file from MetadataMenu#downloadLayouts (XML)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2c62912527240861e2d26bbfac470f06dde70111 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c62912 ] ISIS-993 : only include entities and view models' layouts in zip file from MetadataMenu#downloadLayouts (XML)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bf1288c28759b7f2b0bf0366f89eb4e7f13f9c1c in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf1288c ]

          ISIS-993: minor refactoring of helper methos in GridNormalizerService implementations.

          Show
          jira-bot ASF subversion and git services added a comment - Commit bf1288c28759b7f2b0bf0366f89eb4e7f13f9c1c in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf1288c ] ISIS-993 : minor refactoring of helper methos in GridNormalizerService implementations.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e417a8ab5984393394113066a7ad1ea8379bcab2 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e417a8a ]

          ISIS-993: ensure that actions associated to properties/collections/fieldsets are added in the correct order when normalizing grid.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e417a8ab5984393394113066a7ad1ea8379bcab2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e417a8a ] ISIS-993 : ensure that actions associated to properties/collections/fieldsets are added in the correct order when normalizing grid.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ff4d3427b501b37ee0a36ac3f69d67f39fa79526 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ff4d342 ]

          ISIS-993: extending grid structure to include offsets and allow multiple col-XX-nn to be defined per column.

          Also tidied up the simpleapp:

          • removed .layout.json for HomePageViewModel, replaced with a .layout.xml
          • cleaned up SimpleObject (removing those test collections)
          • removed SimpleObject#updateName action.
          Show
          jira-bot ASF subversion and git services added a comment - Commit ff4d3427b501b37ee0a36ac3f69d67f39fa79526 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ff4d342 ] ISIS-993 : extending grid structure to include offsets and allow multiple col-XX-nn to be defined per column. Also tidied up the simpleapp: removed .layout.json for HomePageViewModel, replaced with a .layout.xml cleaned up SimpleObject (removing those test collections) removed SimpleObject#updateName action.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f763fce110a8bc40c49e5d38fd9b5f63aa4aaf0e in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f763fce ]

          ISIS-993: updating javadoc is all.

          Show
          jira-bot ASF subversion and git services added a comment - Commit f763fce110a8bc40c49e5d38fd9b5f63aa4aaf0e in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f763fce ] ISIS-993 : updating javadoc is all.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2c960ca9eb20756a92d6fe9f77b4c22dc507c267 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c960ca ]

          ISIS-993: removing the ability to view the Grid as a view model (in its own right); no real use case for this functionality at the moment.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2c960ca9eb20756a92d6fe9f77b4c22dc507c267 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c960ca ] ISIS-993 : removing the ability to view the Grid as a view model (in its own right); no real use case for this functionality at the moment.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 393312e4a52a914bfd32d595925b22c700c37187 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=393312e ]

          ISIS-993: fixing unit test from refactoring of SpecificationCacheDefault earlier

          Show
          jira-bot ASF subversion and git services added a comment - Commit 393312e4a52a914bfd32d595925b22c700c37187 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=393312e ] ISIS-993 : fixing unit test from refactoring of SpecificationCacheDefault earlier
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7628fc9d309c8a58ca9f9bbe1e29fa5c5cc044e6 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7628fc9 ]

          ISIS-993: ensure columns in tables are rendered in correct order (require eagerly obtaining grid); also when rendering, ignore any invalid properties/collections/actions.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7628fc9d309c8a58ca9f9bbe1e29fa5c5cc044e6 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7628fc9 ] ISIS-993 : ensure columns in tables are rendered in correct order (require eagerly obtaining grid); also when rendering, ignore any invalid properties/collections/actions.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2c62912527240861e2d26bbfac470f06dde70111 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c62912 ]

          ISIS-993: only include entities and view models' layouts in zip file from MetadataMenu#downloadLayouts (XML)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2c62912527240861e2d26bbfac470f06dde70111 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c62912 ] ISIS-993 : only include entities and view models' layouts in zip file from MetadataMenu#downloadLayouts (XML)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bf1288c28759b7f2b0bf0366f89eb4e7f13f9c1c in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf1288c ]

          ISIS-993: minor refactoring of helper methos in GridNormalizerService implementations.

          Show
          jira-bot ASF subversion and git services added a comment - Commit bf1288c28759b7f2b0bf0366f89eb4e7f13f9c1c in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf1288c ] ISIS-993 : minor refactoring of helper methos in GridNormalizerService implementations.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e417a8ab5984393394113066a7ad1ea8379bcab2 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e417a8a ]

          ISIS-993: ensure that actions associated to properties/collections/fieldsets are added in the correct order when normalizing grid.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e417a8ab5984393394113066a7ad1ea8379bcab2 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e417a8a ] ISIS-993 : ensure that actions associated to properties/collections/fieldsets are added in the correct order when normalizing grid.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e014bf80a823457bdbfc3acb5fac4b4a666715a1 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e014bf8 ]

          ISIS-993: when normalize, bind actions to properties or field sets (if metadata not already specified as an annotation).

          Show
          jira-bot ASF subversion and git services added a comment - Commit e014bf80a823457bdbfc3acb5fac4b4a666715a1 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e014bf8 ] ISIS-993 : when normalize, bind actions to properties or field sets (if metadata not already specified as an annotation).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 62f69d173430efa00c0f06df84ba33aac1c188c1 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=62f69d1 ]

          Merge branch 'master' into ISIS-993

          1. Conflicts:
          2. core/applib/src/main/java/org/apache/isis/applib/services/dto/Dto_downloadXml.java
          3. core/applib/src/main/java/org/apache/isis/applib/services/jaxb/CatalogingSchemaOutputResolver.java
          Show
          jira-bot ASF subversion and git services added a comment - Commit 62f69d173430efa00c0f06df84ba33aac1c188c1 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=62f69d1 ] Merge branch 'master' into ISIS-993 Conflicts: core/applib/src/main/java/org/apache/isis/applib/services/dto/Dto_downloadXml.java core/applib/src/main/java/org/apache/isis/applib/services/jaxb/CatalogingSchemaOutputResolver.java
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit df329882299524e194a7e9d0e86f497421eaa110 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=df32988 ]

          ISIS-993: minor changes, working towards being able to generate .layout.xml for complete vs normalized vs minimal (no longer NPEs for complete etc), however...

          ... not yet correctly roundtripping for anything other than the complete .layout.xml.

          Show
          jira-bot ASF subversion and git services added a comment - Commit df329882299524e194a7e9d0e86f497421eaa110 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=df32988 ] ISIS-993 : minor changes, working towards being able to generate .layout.xml for complete vs normalized vs minimal (no longer NPEs for complete etc), however... ... not yet correctly roundtripping for anything other than the complete .layout.xml.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 48fe231be5f2946d81eb2192ebfbdd958bbe21a6 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=48fe231 ]

          ISIS-993: fixes to prevent SpecificationCacheDefault from getting out-of-whack (by mapping ObjectSpecId to className, rather than spec; can then use the className to look up the spec in turn).

          This stuff came about because reloading of grid after change was only working if invalidated the class spec (= refresh twice).

          Show
          jira-bot ASF subversion and git services added a comment - Commit 48fe231be5f2946d81eb2192ebfbdd958bbe21a6 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=48fe231 ] ISIS-993 : fixes to prevent SpecificationCacheDefault from getting out-of-whack (by mapping ObjectSpecId to className, rather than spec; can then use the className to look up the spec in turn). This stuff came about because reloading of grid after change was only working if invalidated the class spec (= refresh twice).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 34771c2416ba0f798a61595d18faa5dee7be9149 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=34771c2 ]

          ISIS-993: incidental, fix for Lombok with boolean properties (didn't find the @Property annotation).

          Show
          jira-bot ASF subversion and git services added a comment - Commit 34771c2416ba0f798a61595d18faa5dee7be9149 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=34771c2 ] ISIS-993 : incidental, fix for Lombok with boolean properties (didn't find the @Property annotation).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e4637ca801ef72c7861f4d0be1b69ad0c4fc5d6e in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e4637ca ]

          ISIS-993: yet more sorting out of positioning of actions in right drop-down.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e4637ca801ef72c7861f4d0be1b69ad0c4fc5d6e in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e4637ca ] ISIS-993 : yet more sorting out of positioning of actions in right drop-down.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ce2ea3c5da907f886768e5a8a8554548322ebd3d in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ce2ea3c ]

          ISIS-993: further fixes to honour namedEscaped for property edit prompt.

          Show
          jira-bot ASF subversion and git services added a comment - Commit ce2ea3c5da907f886768e5a8a8554548322ebd3d in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ce2ea3c ] ISIS-993 : further fixes to honour namedEscaped for property edit prompt.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0f09648fa41b2af52af61d016842aa0102ab251c in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0f09648 ]

          ISIS-993: more sorting out of positioning of actions in right drop-down.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0f09648fa41b2af52af61d016842aa0102ab251c in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0f09648 ] ISIS-993 : more sorting out of positioning of actions in right drop-down.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1841a12bb02fa30e6223eb65202c8dd2c9e07571 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1841a12 ]

          ISIS-993: honour namedEscaped for property edit prompt.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1841a12bb02fa30e6223eb65202c8dd2c9e07571 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1841a12 ] ISIS-993 : honour namedEscaped for property edit prompt.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c2b07de4bb30a490f4d3f12bab694e6fba161f5 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5c2b07d ]

          ISIS-993: responsibility for creating the default grid moved to GrdNormalizerService. Also Wicket viewer html layout fixes...

          that is:

          • tidying up of ScalarPanelAbstract html/layout, adding missing support for 'edit' button (and use fa-icon for that now, instead).
          • removing spurious concurrency exception resulting from new implementation of edit functionality (from action whose button is rendered on panel).
          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c2b07de4bb30a490f4d3f12bab694e6fba161f5 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5c2b07d ] ISIS-993 : responsibility for creating the default grid moved to GrdNormalizerService. Also Wicket viewer html layout fixes... that is: tidying up of ScalarPanelAbstract html/layout, adding missing support for 'edit' button (and use fa-icon for that now, instead). removing spurious concurrency exception resulting from new implementation of edit functionality (from action whose button is rendered on panel).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e95a46fcbb71d94de906b0a421ede677f96db964 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e95a46f ]

          ISIS-993: removing the fallback components also.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e95a46fcbb71d94de906b0a421ede677f96db964 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e95a46f ] ISIS-993 : removing the fallback components also.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6f435a16558099c12de5bb01af27af1b8a011a5f in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6f435a1 ]

          ISIS-993: fixing bad import and javadoc.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6f435a16558099c12de5bb01af27af1b8a011a5f in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6f435a1 ] ISIS-993 : fixing bad import and javadoc.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bf389208534eb8827892592a68659fd899f55437 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf38920 ]

          ISIS-993: removing support for "isis.viewer.wicket.disableModalDialogs".

          Also:

          • adding stub release and migration notes for 1.12.0.
          Show
          jira-bot ASF subversion and git services added a comment - Commit bf389208534eb8827892592a68659fd899f55437 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf38920 ] ISIS-993 : removing support for "isis.viewer.wicket.disableModalDialogs". Also: adding stub release and migration notes for 1.12.0.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit de3e385f02d1941a569934bdfc583c3839488b08 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=de3e385 ]

          ISIS-993: first-cut of single-edit properties (using modal prompt dialog). Prereq for removing the FixedCol stuff.

          Show
          jira-bot ASF subversion and git services added a comment - Commit de3e385f02d1941a569934bdfc583c3839488b08 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=de3e385 ] ISIS-993 : first-cut of single-edit properties (using modal prompt dialog). Prereq for removing the FixedCol stuff.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e57acf256b1c727475be62fed70e1d6a07f28327 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e57acf2 ]

          ISIS-993: starting to remove the FC (fixed col) stuff ... moving out FCColumn.Hint enum.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e57acf256b1c727475be62fed70e1d6a07f28327 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e57acf2 ] ISIS-993 : starting to remove the FC (fixed col) stuff ... moving out FCColumn.Hint enum.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a40a8696f3fde8e02d82d3bf409052b898d2dc5e in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a40a869 ]

          ISIS-993: reuse Wicket's isVisible() for dynamically visible content (refactor of HasDynamicallyVisibleContent interface).

          Show
          jira-bot ASF subversion and git services added a comment - Commit a40a8696f3fde8e02d82d3bf409052b898d2dc5e in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a40a869 ] ISIS-993 : reuse Wicket's isVisible() for dynamically visible content (refactor of HasDynamicallyVisibleContent interface).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f65487e46008680f6368afc186e5f43513dfc50b in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f65487e4 ]

          ISIS-993: dynamically evaluate visibility of tabpanel, tab, row, col, fieldset and collection (suppress parent containers if there would be nothing to show).

          Show
          jira-bot ASF subversion and git services added a comment - Commit f65487e46008680f6368afc186e5f43513dfc50b in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f65487e4 ] ISIS-993 : dynamically evaluate visibility of tabpanel, tab, row, col, fieldset and collection (suppress parent containers if there would be nothing to show).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 30bfe8c62bbf2fa3894ccc52afb7719cf66f4bca in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=30bfe8c ]

          ISIS-993: improving derivation of properties when layout xml exists with field sets and actions bound to those fieldsets only through @MemberOrder#name annotation.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 30bfe8c62bbf2fa3894ccc52afb7719cf66f4bca in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=30bfe8c ] ISIS-993 : improving derivation of properties when layout xml exists with field sets and actions bound to those fieldsets only through @MemberOrder#name annotation.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 697bcdbc59341a10f4bb6f645bb3c856ab6226fc in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=697bcdb ]

          ISIS-993: better derivation of default grid from existing metadata when none is available.

          Also:

          • allow actions to be associated in @MemberOrder#name with fieldset ids; wire up to first property within that fieldset
          • associate the (framework-provided downloadLayoutXml and downloadJdoMetadata actions with "metadata" fieldset.
          • some fixes for CSS for dropdowns
          Show
          jira-bot ASF subversion and git services added a comment - Commit 697bcdbc59341a10f4bb6f645bb3c856ab6226fc in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=697bcdb ] ISIS-993 : better derivation of default grid from existing metadata when none is available. Also: allow actions to be associated in @MemberOrder#name with fieldset ids; wire up to first property within that fieldset associate the (framework-provided downloadLayoutXml and downloadJdoMetadata actions with "metadata" fieldset. some fixes for CSS for dropdowns
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2bde2a1e50b025d1a052829b99376da77a8a66b2 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2bde2a1 ]

          ISIS-993: suppress properties from fieldsets that should be invisible.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2bde2a1e50b025d1a052829b99376da77a8a66b2 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2bde2a1 ] ISIS-993 : suppress properties from fieldsets that should be invisible.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d2340ebd5839d94b0976f00a530e4daba6c41b45 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d2340eb ]

          ISIS-993: associate properties into their correct fieldsets, honouring ordering. Also order collections.

          in addition:

          • bug fix to suppress not contributed collections (from superclasses) being rendered also as actions
          • tweak to CSS for BS3 layout
          • move DeweyComparator to metamodel module (from runtime module).
          Show
          jira-bot ASF subversion and git services added a comment - Commit d2340ebd5839d94b0976f00a530e4daba6c41b45 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d2340eb ] ISIS-993 : associate properties into their correct fieldsets, honouring ordering. Also order collections. in addition: bug fix to suppress not contributed collections (from superclasses) being rendered also as actions tweak to CSS for BS3 layout move DeweyComparator to metamodel module (from runtime module).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bbd593bc10ab486aad16cc7eff6dd3b2e06a0222 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bbd593b ]

          ISIS-993: guard against invisible actions corresponding to null links.

          Show
          jira-bot ASF subversion and git services added a comment - Commit bbd593bc10ab486aad16cc7eff6dd3b2e06a0222 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bbd593b ] ISIS-993 : guard against invisible actions corresponding to null links.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 959d42477b4aefa383c562f166a91be630e3f3eb in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=959d424 ]

          ISIS-993: GridFacetDefault now derives a grid from facets if no XML is available.

          This design probably means that a lot of the existing "fixedcol" code could be removed; in effect we always render using BS3. Will leave in for the moment, though.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 959d42477b4aefa383c562f166a91be630e3f3eb in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=959d424 ] ISIS-993 : GridFacetDefault now derives a grid from facets if no XML is available. This design probably means that a lot of the existing "fixedcol" code could be removed; in effect we always render using BS3. Will leave in for the moment, though.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 41040399c22304b128f738871dfade1b1eda49c1 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4104039 ]

          Merge branch 'master' into ISIS-993

          Show
          jira-bot ASF subversion and git services added a comment - Commit 41040399c22304b128f738871dfade1b1eda49c1 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4104039 ] Merge branch 'master' into ISIS-993
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 78943221cc6eccc0afed292910bb84a62b8a37bf in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7894322 ]

          ISIS-993: can now download normalized, complete or minimal layouts.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 78943221cc6eccc0afed292910bb84a62b8a37bf in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7894322 ] ISIS-993 : can now download normalized, complete or minimal layouts.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ecf6d1708be0a409cd8fb5d0257235b3b0de1f5b in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ecf6d17 ]

          ISIS-993: hold the domainClass within the grid.

          Show
          jira-bot ASF subversion and git services added a comment - Commit ecf6d1708be0a409cd8fb5d0257235b3b0de1f5b in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ecf6d17 ] ISIS-993 : hold the domainClass within the grid.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6053d1a8efed2d5cae9cbbc8b0497796397686cd in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6053d1a ]

          ISIS-993: fleshing out the GridNormalizerServiceAbstract for the "complete" and "minimal" updating of Grid graphs (prior to conversion to XML).

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6053d1a8efed2d5cae9cbbc8b0497796397686cd in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=6053d1a ] ISIS-993 : fleshing out the GridNormalizerServiceAbstract for the "complete" and "minimal" updating of Grid graphs (prior to conversion to XML).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5c831757d34919ab7b36f84a6e6579a4061a97e3 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5c83175 ]

          ISIS-993: introducing the concept of minimal/normalized/complete grids (still WIP)

          Also:

          • moved responsibility for determining the available set of gridNormalizerServices to GridService (ensure only one such per grid implementation)
          • moved the FC applib classes into the metamodel, so no longer public API.
          Show
          jira-bot ASF subversion and git services added a comment - Commit 5c831757d34919ab7b36f84a6e6579a4061a97e3 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5c83175 ] ISIS-993 : introducing the concept of minimal/normalized/complete grids (still WIP) Also: moved responsibility for determining the available set of gridNormalizerServices to GridService (ensure only one such per grid implementation) moved the FC applib classes into the metamodel, so no longer public API.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f3e8bbfc052a060e80ae350999b787438b0d4168 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f3e8bbf ]

          ISIS-993: improving the suppression algorithm, now search for any content under a tab (however deep), if none found then suppress the tab (which may in turn mean suppressing the tab group and just rendering the rows of the first tab).

          Show
          jira-bot ASF subversion and git services added a comment - Commit f3e8bbfc052a060e80ae350999b787438b0d4168 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f3e8bbf ] ISIS-993 : improving the suppression algorithm, now search for any content under a tab (however deep), if none found then suppress the tab (which may in turn mean suppressing the tab group and just rendering the rows of the first tab).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 082916aeb4dcf34949789b0fa01caf47b27437b9 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=082916a ]

          ISIS-993: changed the suppression algorithm: now, will render any tab group with only a single tab as that tab's rows. This allows tab groups to alternate with field sets etc.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 082916aeb4dcf34949789b0fa01caf47b27437b9 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=082916a ] ISIS-993 : changed the suppression algorithm: now, will render any tab group with only a single tab as that tab's rows. This allows tab groups to alternate with field sets etc.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2ae2df1ba64bedad1ce9bf228335194e3bffb258 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2ae2df1 ]

          ISIS-993: if column contains only a single tabgroup and that tabgroup contains only a single tab, then just render the rows within that tab.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2ae2df1ba64bedad1ce9bf228335194e3bffb258 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2ae2df1 ] ISIS-993 : if column contains only a single tabgroup and that tabgroup contains only a single tab, then just render the rows within that tab.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f233f418a340c319648f756436265c7368bd3697 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f233f41 ]

          ISIS-993: deleting unused fields from CollectionContentsMultipleViewsPanel

          Show
          jira-bot ASF subversion and git services added a comment - Commit f233f418a340c319648f756436265c7368bd3697 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f233f41 ] ISIS-993 : deleting unused fields from CollectionContentsMultipleViewsPanel
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 20faf33a050b10e0085b01cc027d6d0ef6dd4386 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=20faf33 ]

          ISIS-993: Now allow unreferenced collections to be associated with columns. Also sorting out hints for collection selection under tabs.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 20faf33a050b10e0085b01cc027d6d0ef6dd4386 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=20faf33 ] ISIS-993 : Now allow unreferenced collections to be associated with columns. Also sorting out hints for collection selection under tabs.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8fcac96481cb21a47d8db0a64a76fa4693d5582d in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8fcac96 ]

          ISIS-993: unreferenced properties/actions/collectoins handling

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8fcac96481cb21a47d8db0a64a76fa4693d5582d in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8fcac96 ] ISIS-993 : unreferenced properties/actions/collectoins handling
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fe46a781eb7472694e705cfd396e630964c3add3 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fe46a78 ]

          ISIS-993: normalizing the BS3 grid, factoring out commonalities into superclass.

          Show
          jira-bot ASF subversion and git services added a comment - Commit fe46a781eb7472694e705cfd396e630964c3add3 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fe46a78 ] ISIS-993 : normalizing the BS3 grid, factoring out commonalities into superclass.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 63d03d29b1929b481f72eed943ca22eacb2124f8 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=63d03d2 ]

          ISIS-993: converting GridNormalizer into a service.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 63d03d29b1929b481f72eed943ca22eacb2124f8 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=63d03d2 ] ISIS-993 : converting GridNormalizer into a service.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7fb6355663b4ccddba24e7ebe47774f56b62c148 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7fb6355 ]

          ISIS-993: renamed Page to Grid, PageFacet to GridFacet, PageService to GridService, PageNormalizerService to GridNormalizerService, BS3PagePanel to BS3GridPanel, FCPagePanel to FCGridPanel,

          Also regenerated bootstrap3.xsd for new id attrs and sorted out an issue with the unreferencedXxx attrs so that they can be optional.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7fb6355663b4ccddba24e7ebe47774f56b62c148 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7fb6355 ] ISIS-993 : renamed Page to Grid, PageFacet to GridFacet, PageService to GridService, PageNormalizerService to GridNormalizerService, BS3PagePanel to BS3GridPanel, FCPagePanel to FCGridPanel, Also regenerated bootstrap3.xsd for new id attrs and sorted out an issue with the unreferencedXxx attrs so that they can be optional.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 25a267a61cf6d4c9ef297f19f134e25dd17e7a91 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=25a267a ]

          ISIS-993: starting on the visitor/normalization stuff for BS3 grid.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 25a267a61cf6d4c9ef297f19f134e25dd17e7a91 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=25a267a ] ISIS-993 : starting on the visitor/normalization stuff for BS3 grid.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c57d8cd8ed656813ae9f17da68f9098450633b74 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c57d8cd ]

          ISIS-993: bootstrap3 layout working, more or less. Still need to do the normalization phase.

          Show
          jira-bot ASF subversion and git services added a comment - Commit c57d8cd8ed656813ae9f17da68f9098450633b74 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c57d8cd ] ISIS-993 : bootstrap3 layout working, more or less. Still need to do the normalization phase.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 84c9cf7585ddb4d8870c423643025bc29ca1df63 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=84c9cf7 ]

          ISIS-993: use a single layoutMetadata hint in EntityModel, rather than many different hints. Also, moved FC classes under a new "fixedcols" layout.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 84c9cf7585ddb4d8870c423643025bc29ca1df63 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=84c9cf7 ] ISIS-993 : use a single layoutMetadata hint in EntityModel, rather than many different hints. Also, moved FC classes under a new "fixedcols" layout.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d7a1ee2ddae809ef630d48d32953ae6ae736eedf in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d7a1ee2 ]

          ISIS-993: working towards storing a single hint on the EntityModel

          Show
          jira-bot ASF subversion and git services added a comment - Commit d7a1ee2ddae809ef630d48d32953ae6ae736eedf in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d7a1ee2 ] ISIS-993 : working towards storing a single hint on the EntityModel
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fc59d351325454489fe22382b8c41ac4ae30f1e5 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fc59d35 ]

          ISIS-993: store hint on the column, rather than pass around separately.

          Show
          jira-bot ASF subversion and git services added a comment - Commit fc59d351325454489fe22382b8c41ac4ae30f1e5 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fc59d35 ] ISIS-993 : store hint on the column, rather than pass around separately.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 65f7d320fa95cf45aa6db99f66e1165b2ba4f5d8 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=65f7d32 ]

          ISIS-993: bootstrap3 schema now properly defined and serializing ok. Also juggling around with the common (nee members)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 65f7d320fa95cf45aa6db99f66e1165b2ba4f5d8 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=65f7d32 ] ISIS-993 : bootstrap3 schema now properly defined and serializing ok. Also juggling around with the common (nee members)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8f0abcdb64e98ab5e6d3aa30fd32f62444891a62 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8f0abcd ]

          ISIS-993: introduction of the PageNormalizerService as an internal SPI which keeps track of the different Page implementations and their algorithms for normalizing themselves. The original FixedCol layout is now working again as of this commit.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8f0abcdb64e98ab5e6d3aa30fd32f62444891a62 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8f0abcd ] ISIS-993 : introduction of the PageNormalizerService as an internal SPI which keeps track of the different Page implementations and their algorithms for normalizing themselves. The original FixedCol layout is now working again as of this commit.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 10d80f3a850ad602d775b09098405b3b56c2541a in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=10d80f3 ]

          ISIS-993: still sketching out the layout classes for BS3 and FC (fixed col)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 10d80f3a850ad602d775b09098405b3b56c2541a in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=10d80f3 ] ISIS-993 : still sketching out the layout classes for BS3 and FC (fixed col)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 517b6ccbb3e523f084f739fd73d009a86cc7c6c5 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=517b6cc ]

          ISIS-993: working towards a 'bootstrap3' layout

          Show
          jira-bot ASF subversion and git services added a comment - Commit 517b6ccbb3e523f084f739fd73d009a86cc7c6c5 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=517b6cc ] ISIS-993 : working towards a 'bootstrap3' layout
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b72bce9050b3bc34c32b8a1902fbb7be7789de23 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b72bce9 ]

          Merge branch 'master' into ISIS-993

          Show
          jira-bot ASF subversion and git services added a comment - Commit b72bce9050b3bc34c32b8a1902fbb7be7789de23 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b72bce9 ] Merge branch 'master' into ISIS-993
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 74e5bd0c5ab3bdc4256b748da067414dd3b6be48 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=74e5bd0 ]

          ISIS-993: getting rid of HintUtil class, moving into UiHintContainer.Util

          Show
          jira-bot ASF subversion and git services added a comment - Commit 74e5bd0c5ab3bdc4256b748da067414dd3b6be48 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=74e5bd0 ] ISIS-993 : getting rid of HintUtil class, moving into UiHintContainer.Util
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit efe98ca6efbfea7d55930a3676b1b10e82805cb2 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=efe98ca ]

          ISIS-993: removing one final remnant of UiHintPathSignficant.

          Show
          jira-bot ASF subversion and git services added a comment - Commit efe98ca6efbfea7d55930a3676b1b10e82805cb2 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=efe98ca ] ISIS-993 : removing one final remnant of UiHintPathSignficant.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8b49e1c48311a1195f653b9f09f446b23a41f35c in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8b49e1c ]

          ISIS-993: getting rid of the HasPath interface.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8b49e1c48311a1195f653b9f09f446b23a41f35c in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8b49e1c ] ISIS-993 : getting rid of the HasPath interface.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b8576fce76150fbcc3a179fc3935041c22b665e9 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b8576fc ]

          ISIS-993: getting rid of UiHintSignificantComponent

          Show
          jira-bot ASF subversion and git services added a comment - Commit b8576fce76150fbcc3a179fc3935041c22b665e9 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b8576fc ] ISIS-993 : getting rid of UiHintSignificantComponent
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0cefc70732995d60e3be242eacb1597a3e2ebf1e in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0cefc70 ]

          ISIS-993: ScopedSessionAttribute now using Component rather than HasPath. That means that the state of the page (selected tabs, selected collection view) is being persisted and honoured in the session correctly.

          Also added in new implementations of UiHintPathSignificant, however this bit is incomplete... hacked the fullHintPathFor(...) to ignore the fact as to whether a component is "UI Hint path significant" or not. Intention in next commit is to simplify and get rid of this interface, just use all the components in the page as being significant.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0cefc70732995d60e3be242eacb1597a3e2ebf1e in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0cefc70 ] ISIS-993 : ScopedSessionAttribute now using Component rather than HasPath. That means that the state of the page (selected tabs, selected collection view) is being persisted and honoured in the session correctly. Also added in new implementations of UiHintPathSignificant, however this bit is incomplete... hacked the fullHintPathFor(...) to ignore the fact as to whether a component is "UI Hint path significant" or not. Intention in next commit is to simplify and get rid of this interface, just use all the components in the page as being significant.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bdbd5036fcd5823efaaad645923b92b2a6628c8d in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bdbd503 ]

          ISIS-993: factored out EntityCollectionPanel from EntityCollectionsPanel.

          Show
          jira-bot ASF subversion and git services added a comment - Commit bdbd5036fcd5823efaaad645923b92b2a6628c8d in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bdbd503 ] ISIS-993 : factored out EntityCollectionPanel from EntityCollectionsPanel.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c05bde0f5e9358db24ee9124243ef7856bfdc1b7 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c05bde0 ]

          ISIS-993: create the EntityCollectionModel from the EntityModel with CollectionLayoutMetadata, rather than passing the OTMA around.

          Show
          jira-bot ASF subversion and git services added a comment - Commit c05bde0f5e9358db24ee9124243ef7856bfdc1b7 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c05bde0 ] ISIS-993 : create the EntityCollectionModel from the EntityModel with CollectionLayoutMetadata, rather than passing the OTMA around.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f33e0e243d3f6aff68698487cc9a84e89c2a4096 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f33e0e2 ]

          ISIS-993: just starting on refactoring out EntityCollection (cf PropertyGroup) from EntityCollections (WIP).

          Show
          jira-bot ASF subversion and git services added a comment - Commit f33e0e243d3f6aff68698487cc9a84e89c2a4096 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f33e0e2 ] ISIS-993 : just starting on refactoring out EntityCollection (cf PropertyGroup) from EntityCollections (WIP).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2da70738784f35a4d3de17210b45c02dad8d5679 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2da7073 ]

          ISIS-993: removing myBlockContainer CSS class, not used since bootstrap refactor for v1.8.0

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2da70738784f35a4d3de17210b45c02dad8d5679 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2da7073 ] ISIS-993 : removing myBlockContainer CSS class, not used since bootstrap refactor for v1.8.0
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1f764b506970528862c5cf81209335674d53ea62 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1f764b5 ]

          ISIS-993: factored out PropertyGroup component.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1f764b506970528862c5cf81209335674d53ea62 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1f764b5 ] ISIS-993 : factored out PropertyGroup component.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 205cf8539457f8294daa723301e75b615ca0de89 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=205cf85 ]

          ISIS-993: working towards factoring out a PropertyGroup component.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 205cf8539457f8294daa723301e75b615ca0de89 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=205cf85 ] ISIS-993 : working towards factoring out a PropertyGroup component.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit cddf255555c3af8e41fc758f1b22b618d143cb4f in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cddf255 ]

          ISIS-993: attempting to unify the existing UiHintContainer and the ScopedSessionAttribute stuff; only part way there.

          Show
          jira-bot ASF subversion and git services added a comment - Commit cddf255555c3af8e41fc758f1b22b618d143cb4f in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cddf255 ] ISIS-993 : attempting to unify the existing UiHintContainer and the ScopedSessionAttribute stuff; only part way there.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 376ab6f06d716005d9073a6022c82730e3401c9b in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=376ab6f ]

          ISIS-993: can now store multiple different session attributes on an EntityCollectionModel.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 376ab6f06d716005d9073a6022c82730e3401c9b in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=376ab6f ] ISIS-993 : can now store multiple different session attributes on an EntityCollectionModel.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 35201392b424e507e6fc54d6fe8e7381e37b04c8 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3520139 ]

          ISIS-993: SessionScopedAttribute factored out, now used for the selectedItem drop-down so that the system remembers which view to use for rendering a collection (for a particular object).

          Show
          jira-bot ASF subversion and git services added a comment - Commit 35201392b424e507e6fc54d6fe8e7381e37b04c8 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3520139 ] ISIS-993 : SessionScopedAttribute factored out, now used for the selectedItem drop-down so that the system remembers which view to use for rendering a collection (for a particular object).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d946027a36293d3e800c393f01aa145b8bc23b20 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d946027 ]

          ISIS-993: renaming of components, EntityCombinedPanel now called EntityEditablePanel. Other subsidiary panels moved alongside.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d946027a36293d3e800c393f01aa145b8bc23b20 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d946027 ] ISIS-993 : renaming of components, EntityCombinedPanel now called EntityEditablePanel. Other subsidiary panels moved alongside.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e647a951ebdaecb73b1dd1938559b0aeb163ff5d in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e647a95 ]

          ISIS-993: renaming of the view metadata classes.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e647a951ebdaecb73b1dd1938559b0aeb163ff5d in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e647a95 ] ISIS-993 : renaming of the view metadata classes.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fc5355f5dad5b81e67d0e3f1121b5e88ecf4e3fe in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fc5355f ]

          ISIS-993: in process of converting TabbedPanel into own panel.

          Show
          jira-bot ASF subversion and git services added a comment - Commit fc5355f5dad5b81e67d0e3f1121b5e88ecf4e3fe in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fc5355f ] ISIS-993 : in process of converting TabbedPanel into own panel.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b04c27ff347ca314e5e68b78e8a9107dc96f3c4e in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b04c27f ]

          ISIS-993: optional left and right columns either side of tab groups; tweaks to CSS; HasPath for all elements of the layout metadata classes (working towards support for persistence of widget state and hints)

          Show
          jira-bot ASF subversion and git services added a comment - Commit b04c27ff347ca314e5e68b78e8a9107dc96f3c4e in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b04c27f ] ISIS-993 : optional left and right columns either side of tab groups; tweaks to CSS; HasPath for all elements of the layout metadata classes (working towards support for persistence of widget state and hints)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d83b2cfed6e9d437d77e0f4e4edd0a7756509f72 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d83b2cf ]

          ISIS-993: entity page now remembers the selected tab (in session) on a per-object basis

          Show
          jira-bot ASF subversion and git services added a comment - Commit d83b2cfed6e9d437d77e0f4e4edd0a7756509f72 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d83b2cf ] ISIS-993 : entity page now remembers the selected tab (in session) on a per-object basis
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c3b614c28fa7f630f0f5834180fa4923bb0d2ab0 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c3b614c ]

          ISIS-993: simplifying and finetuning.

          • layout.json disabled completely if a layout.xml is discovered
          • got rid of the enable/disable dynamic reloading, went back to checking deployment category for isProduction mode or not
          • ObjectLayoutMetadataService caches bad XML and also maintains xml -> metadata map (non-prod mode only)
          • blacklisting only applies if in non-prod mode
          • combined getMetadata() and reloadMetadata()
          • ensure that members are sorted correctly when in property groups (within their col / tab)
          • set up service specifications as being markAsService eagerly, rather than later on.
          • removing EntityCombinedPanelFactory, now use EntityTabGroupsPanelFactory for both cases.
          Show
          jira-bot ASF subversion and git services added a comment - Commit c3b614c28fa7f630f0f5834180fa4923bb0d2ab0 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c3b614c ] ISIS-993 : simplifying and finetuning. layout.json disabled completely if a layout.xml is discovered got rid of the enable/disable dynamic reloading, went back to checking deployment category for isProduction mode or not ObjectLayoutMetadataService caches bad XML and also maintains xml -> metadata map (non-prod mode only) blacklisting only applies if in non-prod mode combined getMetadata() and reloadMetadata() ensure that members are sorted correctly when in property groups (within their col / tab) set up service specifications as being markAsService eagerly, rather than later on. removing EntityCombinedPanelFactory, now use EntityTabGroupsPanelFactory for both cases.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2b170467aa2be346363635be8ed884bafdc201c5 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2b17046 ]

          ISIS-993: no longer show edit buttons for tabbed panel; sorted out a rendering issue of Blob/Clob when in tabbed view.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2b170467aa2be346363635be8ed884bafdc201c5 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2b17046 ] ISIS-993 : no longer show edit buttons for tabbed panel; sorted out a rendering issue of Blob/Clob when in tabbed view.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 47f4aea4b39e688ab0f9b750c2419976b7958a30 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=47f4aea ]

          ISIS-993: working towards getting dynamic reloading working smoothly - not there yet.

          • moved responsibility for reading the XML to ObjectLayoutMetadataFacet (not certain if that was a good idea).
          • Update to MedataMenu to switch on/off dynamic layouts. Don't invalidate entire spec, instead just reload the metadata.
          • EntityModel cloning now shares the assocated ScalarModel map (a shallow clone), needed for edit form
          • ObjectReflectorDefault only eagerly loads specs for contributed services and mixins, in an attempt to reduce startup time
          • EntityTabGroupsPanelFactory now created ether the EntityTabGroupsPanel or the original EntityCombinedPanel, depending on whether there is layout.xml metadata
          • added some further convenience methods to ObjectLayoutMetadata.

          What I would like to do is to eagerly load up the layout.xml up front rather than lazily. However, attempting to do that caused a stackoverflow, and not sure why. As things stand I also have an issue with edit failing for the todoapp if no layout data at all, not sure why.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 47f4aea4b39e688ab0f9b750c2419976b7958a30 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=47f4aea ] ISIS-993 : working towards getting dynamic reloading working smoothly - not there yet. moved responsibility for reading the XML to ObjectLayoutMetadataFacet (not certain if that was a good idea). Update to MedataMenu to switch on/off dynamic layouts. Don't invalidate entire spec, instead just reload the metadata. EntityModel cloning now shares the assocated ScalarModel map (a shallow clone), needed for edit form ObjectReflectorDefault only eagerly loads specs for contributed services and mixins, in an attempt to reduce startup time EntityTabGroupsPanelFactory now created ether the EntityTabGroupsPanel or the original EntityCombinedPanel, depending on whether there is layout.xml metadata added some further convenience methods to ObjectLayoutMetadata. What I would like to do is to eagerly load up the layout.xml up front rather than lazily. However, attempting to do that caused a stackoverflow, and not sure why. As things stand I also have an issue with edit failing for the todoapp if no layout data at all, not sure why.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit aacec3b49a2a918a14d2136c0e447118ee24d4f4 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=aacec3b ]

          ISIS-993: factored out EntityColumnMembers

          Show
          jira-bot ASF subversion and git services added a comment - Commit aacec3b49a2a918a14d2136c0e447118ee24d4f4 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=aacec3b ] ISIS-993 : factored out EntityColumnMembers
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f9f43c29685c6bc8d7c26c7331f75bcd2b5faf54 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f9f43c2 ]

          ISIS-993: remove the 'first-field' class appender, since doesn't seem to be used

          Show
          jira-bot ASF subversion and git services added a comment - Commit f9f43c29685c6bc8d7c26c7331f75bcd2b5faf54 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f9f43c2 ] ISIS-993 : remove the 'first-field' class appender, since doesn't seem to be used
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d41f2d13c234a22bdab14a5172619e62f4b1a80e in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d41f2d1 ]

          ISIS-993: fixed the OK/edit issue.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d41f2d13c234a22bdab14a5172619e62f4b1a80e in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d41f2d1 ] ISIS-993 : fixed the OK/edit issue.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9bad36c92dc61e3465c757c101a7f11d93256bf5 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9bad36c ]

          ISIS-993: further refactoring, working towards factoring out EntityColumnMembers. However getting an exception when there are two tab groups (with the id/feedback... not sure why yet).

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9bad36c92dc61e3465c757c101a7f11d93256bf5 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9bad36c ] ISIS-993 : further refactoring, working towards factoring out EntityColumnMembers. However getting an exception when there are two tab groups (with the id/feedback... not sure why yet).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 01781b8c1371f7245f5a38d9c5f55baa2c9f4396 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=01781b8 ]

          ISIS-993: refactoring EntityPropertiesForm so can factor out a new component.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 01781b8c1371f7245f5a38d9c5f55baa2c9f4396 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=01781b8 ] ISIS-993 : refactoring EntityPropertiesForm so can factor out a new component.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e3b93b6adf20d430a29afdd82f053722d7ec0abf in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e3b93b6 ]

          ISIS-993: optional left and right columns either side of tab groups; tweaks to CSS; HasPath for all elements of the layout metadata classes (working towards support for persistence of widget state and hints)

          Show
          jira-bot ASF subversion and git services added a comment - Commit e3b93b6adf20d430a29afdd82f053722d7ec0abf in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e3b93b6 ] ISIS-993 : optional left and right columns either side of tab groups; tweaks to CSS; HasPath for all elements of the layout metadata classes (working towards support for persistence of widget state and hints)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 04041d78a1d534126c0990157f5baa5fc9d0a55c in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=04041d7 ]

          ISIS-993: entity page now remembers the selected tab (in session) on a per-object basis

          Show
          jira-bot ASF subversion and git services added a comment - Commit 04041d78a1d534126c0990157f5baa5fc9d0a55c in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=04041d7 ] ISIS-993 : entity page now remembers the selected tab (in session) on a per-object basis
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit aa720f384003df11ff8e5e4b9c46b0166b5b7e56 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=aa720f3 ]

          ISIS-993: simplifying and finetuning.

          • layout.json disabled completely if a layout.xml is discovered
          • got rid of the enable/disable dynamic reloading, went back to checking deployment category for isProduction mode or not
          • ObjectLayoutMetadataService caches bad XML and also maintains xml -> metadata map (non-prod mode only)
          • blacklisting only applies if in non-prod mode
          • combined getMetadata() and reloadMetadata()
          • ensure that members are sorted correctly when in property groups (within their col / tab)
          • set up service specifications as being markAsService eagerly, rather than later on.
          • removing EntityCombinedPanelFactory, now use EntityTabGroupsPanelFactory for both cases.
          Show
          jira-bot ASF subversion and git services added a comment - Commit aa720f384003df11ff8e5e4b9c46b0166b5b7e56 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=aa720f3 ] ISIS-993 : simplifying and finetuning. layout.json disabled completely if a layout.xml is discovered got rid of the enable/disable dynamic reloading, went back to checking deployment category for isProduction mode or not ObjectLayoutMetadataService caches bad XML and also maintains xml -> metadata map (non-prod mode only) blacklisting only applies if in non-prod mode combined getMetadata() and reloadMetadata() ensure that members are sorted correctly when in property groups (within their col / tab) set up service specifications as being markAsService eagerly, rather than later on. removing EntityCombinedPanelFactory, now use EntityTabGroupsPanelFactory for both cases.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 021711edfde36f4b7e7f85930b286f41f0ae23c3 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=021711e ]

          ISIS-993: no longer show edit buttons for tabbed panel; sorted out a rendering issue of Blob/Clob when in tabbed view.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 021711edfde36f4b7e7f85930b286f41f0ae23c3 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=021711e ] ISIS-993 : no longer show edit buttons for tabbed panel; sorted out a rendering issue of Blob/Clob when in tabbed view.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9ebaee6567ac2655b50b5705342b1fd91448ceca in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9ebaee6 ]

          ISIS-993: working towards getting dynamic reloading working smoothly - not there yet.

          • moved responsibility for reading the XML to ObjectLayoutMetadataFacet (not certain if that was a good idea).
          • Update to MedataMenu to switch on/off dynamic layouts. Don't invalidate entire spec, instead just reload the metadata.
          • EntityModel cloning now shares the assocated ScalarModel map (a shallow clone), needed for edit form
          • ObjectReflectorDefault only eagerly loads specs for contributed services and mixins, in an attempt to reduce startup time
          • EntityTabGroupsPanelFactory now created ether the EntityTabGroupsPanel or the original EntityCombinedPanel, depending on whether there is layout.xml metadata
          • added some further convenience methods to ObjectLayoutMetadata.

          What I would like to do is to eagerly load up the layout.xml up front rather than lazily. However, attempting to do that caused a stackoverflow, and not sure why. As things stand I also have an issue with edit failing for the todoapp if no layout data at all, not sure why.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9ebaee6567ac2655b50b5705342b1fd91448ceca in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9ebaee6 ] ISIS-993 : working towards getting dynamic reloading working smoothly - not there yet. moved responsibility for reading the XML to ObjectLayoutMetadataFacet (not certain if that was a good idea). Update to MedataMenu to switch on/off dynamic layouts. Don't invalidate entire spec, instead just reload the metadata. EntityModel cloning now shares the assocated ScalarModel map (a shallow clone), needed for edit form ObjectReflectorDefault only eagerly loads specs for contributed services and mixins, in an attempt to reduce startup time EntityTabGroupsPanelFactory now created ether the EntityTabGroupsPanel or the original EntityCombinedPanel, depending on whether there is layout.xml metadata added some further convenience methods to ObjectLayoutMetadata. What I would like to do is to eagerly load up the layout.xml up front rather than lazily. However, attempting to do that caused a stackoverflow, and not sure why. As things stand I also have an issue with edit failing for the todoapp if no layout data at all, not sure why.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit da0fd23d364c529480aebfa4be44690e9d497a49 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=da0fd23 ]

          ISIS-993: factored out EntityColumnMembers

          Show
          jira-bot ASF subversion and git services added a comment - Commit da0fd23d364c529480aebfa4be44690e9d497a49 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=da0fd23 ] ISIS-993 : factored out EntityColumnMembers
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1613be379d5d5e577854b45a2de6d403064c1296 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1613be3 ]

          ISIS-993: remove the 'first-field' class appender, since doesn't seem to be used

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1613be379d5d5e577854b45a2de6d403064c1296 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1613be3 ] ISIS-993 : remove the 'first-field' class appender, since doesn't seem to be used
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 873cc2e2e86df4f3e43d691ef9313d03c5313745 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=873cc2e ]

          ISIS-993: fixed the OK/edit issue.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 873cc2e2e86df4f3e43d691ef9313d03c5313745 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=873cc2e ] ISIS-993 : fixed the OK/edit issue.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9ff3c29d8d5c03a9bb4c6d1d605222cca83731e6 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9ff3c29 ]

          ISIS-993: further refactoring, working towards factoring out EntityColumnMembers. However getting an exception when there are two tab groups (with the id/feedback... not sure why yet).

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9ff3c29d8d5c03a9bb4c6d1d605222cca83731e6 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9ff3c29 ] ISIS-993 : further refactoring, working towards factoring out EntityColumnMembers. However getting an exception when there are two tab groups (with the id/feedback... not sure why yet).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit cd82ef82afcb98bcb26d39ce227d8fe7c605f6f4 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cd82ef8 ]

          ISIS-993: refactoring EntityPropertiesForm so can factor out a new component.

          Show
          jira-bot ASF subversion and git services added a comment - Commit cd82ef82afcb98bcb26d39ce227d8fe7c605f6f4 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=cd82ef8 ] ISIS-993 : refactoring EntityPropertiesForm so can factor out a new component.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9597245f8d27db5320031ca7db465fa5da92f1b0 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9597245 ]

          ISIS-993: add the ObjectLayoutMetadata#actions collection if null

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9597245f8d27db5320031ca7db465fa5da92f1b0 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=9597245 ] ISIS-993 : add the ObjectLayoutMetadata#actions collection if null
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3bfcae8c355af10e0a7dec037a17750ecdffe05f in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3bfcae8 ]

          ISIS-993: started working on adding a fixed column to right hand side

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3bfcae8c355af10e0a7dec037a17750ecdffe05f in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3bfcae8 ] ISIS-993 : started working on adding a fixed column to right hand side
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 70397aadf132bd470af77d1cb9809f73a991c055 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=70397aa ]

          ISIS-993: now rendering properties and collections in tabs ok.

          Some stuff still to do:

          • provide a far-right column that is not tabbed at all.
          • better handling of column spans, to adjust if spans don't sum to 12 correctly.
          • layout views don't render.
          • allow layout views be edited and, perhaps, shared via settings.
          • hints should be extended
          Show
          jira-bot ASF subversion and git services added a comment - Commit 70397aadf132bd470af77d1cb9809f73a991c055 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=70397aa ] ISIS-993 : now rendering properties and collections in tabs ok. Some stuff still to do: provide a far-right column that is not tabbed at all. better handling of column spans, to adjust if spans don't sum to 12 correctly. layout views don't render. allow layout views be edited and, perhaps, shared via settings. hints should be extended
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2cb78cf0112e1213717223f9cfd442c04d68bb60 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2cb78cf ]

          ISIS-993: more on the layout service, ability to download a zip of all layouts

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2cb78cf0112e1213717223f9cfd442c04d68bb60 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2cb78cf ] ISIS-993 : more on the layout service, ability to download a zip of all layouts
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4da8f960ce4cfe8f386ff2a0de3fa0ae46609eeb in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4da8f96 ]

          ISIS-993: factored out LayoutMetadataService, renamed the metadata classes

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4da8f960ce4cfe8f386ff2a0de3fa0ae46609eeb in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4da8f96 ] ISIS-993 : factored out LayoutMetadataService, renamed the metadata classes
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0ac8eda9ae352210b1d6262f10ce3f6d46c7bf1d in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0ac8eda ]

          ISIS-993: slight simplification to metadata to make easier to fit into existing wicket cpt implementation; Wicket components now rendering again

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0ac8eda9ae352210b1d6262f10ce3f6d46c7bf1d in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0ac8eda ] ISIS-993 : slight simplification to metadata to make easier to fit into existing wicket cpt implementation; Wicket components now rendering again
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 739899bada81ca19290ab6c6333598e81aa7483f in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=739899b ]

          ISIS-993: simplifying the metadata. the wicket components still broken at this point

          Show
          jira-bot ASF subversion and git services added a comment - Commit 739899bada81ca19290ab6c6333598e81aa7483f in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=739899b ] ISIS-993 : simplifying the metadata. the wicket components still broken at this point
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 165202f603ff7eb858f51f7f5a80df0f97e0b23d in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=165202f ]

          ISIS-993: metadata has back owners. Wicket component broken at this point

          Show
          jira-bot ASF subversion and git services added a comment - Commit 165202f603ff7eb858f51f7f5a80df0f97e0b23d in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=165202f ] ISIS-993 : metadata has back owners. Wicket component broken at this point
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b590c97916b94cde577c12e2569d9a35d8ef958c in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b590c97 ]

          ISIS-993: started to add tab component

          Show
          jira-bot ASF subversion and git services added a comment - Commit b590c97916b94cde577c12e2569d9a35d8ef958c in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b590c97 ] ISIS-993 : started to add tab component
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 19b7e0eb2cfbdee9e3a4b0e32442bef79bcfd766 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=19b7e0e ]

          ISIS-993: pretty much there on deriving and syncing the metamodel with the layout.xml info;

          next step is to do the new Wicket views for the tabs themselves

          Show
          jira-bot ASF subversion and git services added a comment - Commit 19b7e0eb2cfbdee9e3a4b0e32442bef79bcfd766 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=19b7e0e ] ISIS-993 : pretty much there on deriving and syncing the metamodel with the layout.xml info; next step is to do the new Wicket views for the tabs themselves
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c10162856c0f8cb87a5d7e09f2b3a4b5840fff9b in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c101628 ]

          ISIS-993: working on the fleshing out stuff (to default missing layout metadata)

          Show
          jira-bot ASF subversion and git services added a comment - Commit c10162856c0f8cb87a5d7e09f2b3a4b5840fff9b in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c101628 ] ISIS-993 : working on the fleshing out stuff (to default missing layout metadata)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2988aef22ba6eb15391fd95dd2b0b7867a756b90 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2988aef ]

          ISIS-993: improving the usability of the schema; minor stuff for wicket components

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2988aef22ba6eb15391fd95dd2b0b7867a756b90 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2988aef ] ISIS-993 : improving the usability of the schema; minor stuff for wicket components
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 599e179d8146ab08a394dd9796d7c90568344de6 in isis's branch refs/heads/ISIS-993 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=599e179 ]

          ISIS-993: metadata classes, facet factory, starting on the wicket component

          Show
          jira-bot ASF subversion and git services added a comment - Commit 599e179d8146ab08a394dd9796d7c90568344de6 in isis's branch refs/heads/ ISIS-993 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=599e179 ] ISIS-993 : metadata classes, facet factory, starting on the wicket component

            People

            • Assignee:
              danhaywood Dan Haywood
              Reporter:
              danhaywood Dan Haywood
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development