Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-785

Invoke action parameter with a collection of entities.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.14.0
    • Component/s: Core, Core: Viewer: Wicket
    • Labels:
      None

      Description

      Overlaps with ISIS-709

      As an Isis user
      I want to pass as an action parameter a collection of entities
      In order to avoid repetitive work to the end-user

      ~~~
      One possible prog model API would be to annotate one of the action params with a new annotation, named @BulkParam, such as in:

      public class TodoItem {

      ...
      private TodoItem parentTodoItem;

      ....

      public void addRelatedTodo(@Named("To-Do Item") @BulkParam TodoItem todoItem, @Named("Comments") String comments)

      { .... }

      ...

      }

      Where the viewer founds it, instead of asking for one TodoItem, it will allow the user to select multiple items.
      Once done, it will execute the action multiple times, passing each time one of the TodoItem selected.
      If there are other params, the viewer will pass on each action invokation the same value for all them.
      Only one param can be annotated with @BulkParam, for avoiding combinatorial explosion (10 items selected of one param, 10 items on the other param would require to be execute 100 times, one for each combination).

      The User Interface could be adapted to the choices or autocomplete parameter facets, for easing the work of the user.

      If "choices", there can be alternative displays (see https://plugins.jquery.com/tag/multiselect/):
      1. the viewer can present the user a grid or checkbox (like the one in http://liveline.github.io/jquery-checkallbox/) with all choices, and the user can check any of them. Alternative: http://www.ryancramer.com/journal/entries/select_multiple/
      2. multi-select drop-down, like this ones: http://ivaynberg.github.io/select2/, http://harvesthq.github.io/chosen/, https://github.com/ehynds/jquery-ui-multiselect-widget, http://www.droplist.vinmein.com/. They require minimal changes on the current actions dialog, but does not allow to always view all choices selected (I could live with it).

      If "autocomplete":
      1. It could be based on a two panels disposition, left and right, where the user incrementally searches on an edit box placed over the left panel, similar to current autocomplete implementation, but placing on the left panel : http://quasipartikel.at/multiselect_next/
      2. Similar approach to the "choices" one, also with this same widget that admits remote dataset loading and min number of chars entered: http://ivaynberg.github.io/select2/

      As seen, a widget like http://ivaynberg.github.io/select2/ would allow to solve both situations without requiring much changes on the viewer’s action dialog.

        Issue Links

          Activity

          Hide
          danhaywood Dan Haywood added a comment -

          This ticket was originally created as ISIS-764, but was cloned from it when ISIS-764 was used to do some preparatory work.

          Show
          danhaywood Dan Haywood added a comment - This ticket was originally created as ISIS-764 , but was cloned from it when ISIS-764 was used to do some preparatory work.
          Hide
          danhaywood Dan Haywood added a comment -

          (I've cloned this from ISIS-764, which has now been "repurposed" to some prereq work that will help in implementing this story).

          Show
          danhaywood Dan Haywood added a comment - (I've cloned this from ISIS-764 , which has now been "repurposed" to some prereq work that will help in implementing this story).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b993efe4628552d7f974d5dbf34eaff1e263db4b in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b993efe ]

          ISIS-785: extends FacetedMethod#getParameters to also add the TypeOfFacet to the FacetedMethodParameter if it represents a parameter of type Collection<T>. Calls new SpecificationLoader#inferFromGenericParamType

          Along the way, added SpecificationLoader to FacetedMethod#createForAction (so can delegate across to SpecificationLoader#infer... methods).

          Show
          jira-bot ASF subversion and git services added a comment - Commit b993efe4628552d7f974d5dbf34eaff1e263db4b in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b993efe ] ISIS-785 : extends FacetedMethod#getParameters to also add the TypeOfFacet to the FacetedMethodParameter if it represents a parameter of type Collection<T>. Calls new SpecificationLoader#inferFromGenericParamType Along the way, added SpecificationLoader to FacetedMethod#createForAction (so can delegate across to SpecificationLoader#infer... methods).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8d807129115c82fc172252fd1cf8776c44dbdc59 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8d80712 ]

          ISIS-785: now sets the type on the FactedMethodParameter peer object when represents collection, meaning that ...

          ... an action "foo(Collection<Customer> cust)" is compatible with supporting method "List<Customer> choices0Foo()"

          Still WIP ... at this point, fails when attempt to invoke the action, passing an object rather than a collection of objects.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8d807129115c82fc172252fd1cf8776c44dbdc59 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=8d80712 ] ISIS-785 : now sets the type on the FactedMethodParameter peer object when represents collection, meaning that ... ... an action "foo(Collection<Customer> cust)" is compatible with supporting method "List<Customer> choices0Foo()" Still WIP ... at this point, fails when attempt to invoke the action, passing an object rather than a collection of objects.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d51d4aa6beb84323b580213293b84d7877cb7e24 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d51d4aa ]

          ISIS-785: splits FeatureType#ACTION_PARAMETER into #ACTION_PARAMETER_SCALAR and #ACTION_PARAMETER_COLLECTION, so able to create either OneToOneActionParameter or OneToManyActionParameter.

          ...

          Show
          jira-bot ASF subversion and git services added a comment - Commit d51d4aa6beb84323b580213293b84d7877cb7e24 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d51d4aa ] ISIS-785 : splits FeatureType#ACTION_PARAMETER into #ACTION_PARAMETER_SCALAR and #ACTION_PARAMETER_COLLECTION, so able to create either OneToOneActionParameter or OneToManyActionParameter. ...
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d6d0c195c2f10f67a39dee3f81eb90f035c6f112 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d6d0c19 ]

          ISIS-785: introduces ActionArgumentModel as the API between ActionParametersFormPanel and ScalarModel; introduces ActionArgumentCollectionModel as an implementation to represent collection arguments.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d6d0c195c2f10f67a39dee3f81eb90f035c6f112 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d6d0c19 ] ISIS-785 : introduces ActionArgumentModel as the API between ActionParametersFormPanel and ScalarModel; introduces ActionArgumentCollectionModel as an implementation to represent collection arguments.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bc9320e9fb45bcfeebb06fb01b507dd696f8013f in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bc9320e ]

          ISIS-785: cleans up some redundant imports is all

          Show
          jira-bot ASF subversion and git services added a comment - Commit bc9320e9fb45bcfeebb06fb01b507dd696f8013f in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bc9320e ] ISIS-785 : cleans up some redundant imports is all
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a6a79e48f8efad7e08a1480ad49bb1e3ceb674d1 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a6a79e4 ]

          ISIS-785: removes implementation of ActionArgumentCollectionModel, gonna use ScalarModel after all.

          Show
          jira-bot ASF subversion and git services added a comment - Commit a6a79e48f8efad7e08a1480ad49bb1e3ceb674d1 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a6a79e4 ] ISIS-785 : removes implementation of ActionArgumentCollectionModel, gonna use ScalarModel after all.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 69753e24b23e1e1c0b2682e54b047560b69226d6 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=69753e2 ]

          ISIS-785: introduces CollectionSemanticsFacet for both OneToManyParameter and also OneToManyAssociation, and use to capture from the param type/return type using FacetMethodParam or FacetMethod, earlier on.

          The previous design, which attempted to infer CollectionSemantics later on, was broken because the TypedFacetHolder#getType / #setType capture only the element type of the collection, not the type of the collection itself.

          This commit also extends CollectionSemantics to add in SORTED_SET as well as SET.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 69753e24b23e1e1c0b2682e54b047560b69226d6 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=69753e2 ] ISIS-785 : introduces CollectionSemanticsFacet for both OneToManyParameter and also OneToManyAssociation, and use to capture from the param type/return type using FacetMethodParam or FacetMethod, earlier on. The previous design, which attempted to infer CollectionSemantics later on, was broken because the TypedFacetHolder#getType / #setType capture only the element type of the collection, not the type of the collection itself. This commit also extends CollectionSemantics to add in SORTED_SET as well as SET.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fbc259fb01c88a9016e66380e5c2744ef5499a3d in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fbc259f ]

          ISIS-785: adds some missing 'final' modifiers, is all.

          Show
          jira-bot ASF subversion and git services added a comment - Commit fbc259fb01c88a9016e66380e5c2744ef5499a3d in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fbc259f ] ISIS-785 : adds some missing 'final' modifiers, is all.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e114e6ccf60dcc2494de099e491192f4c3d2f19a in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e114e6c ]

          ISIS-785: wrapped Select2Choice with a Select2 wrapper class, idea being to encapsulate whether use Select2Choice or Select2MultiChoice.

          Added ScalarModel#isCollection() - true if for an action parameter with featureType of ACTION_PARAMETER_COLL , and treat its ObjectAdapterMemento as a memento for a adapter of a transient java.util.ArrayList that contains (persistent) pojos.

          Show
          jira-bot ASF subversion and git services added a comment - Commit e114e6ccf60dcc2494de099e491192f4c3d2f19a in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e114e6c ] ISIS-785 : wrapped Select2Choice with a Select2 wrapper class, idea being to encapsulate whether use Select2Choice or Select2MultiChoice. Added ScalarModel#isCollection() - true if for an action parameter with featureType of ACTION_PARAMETER_COLL , and treat its ObjectAdapterMemento as a memento for a adapter of a transient java.util.ArrayList that contains (persistent) pojos.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fadb7ec780de2a714b96b444429464e3f8b59c07 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fadb7ec ]

          ISIS-785: reworks ObjectAdapterMemento so can store a list of OAMs (equivalent to a transient list of persistent entities) as well as a single OAM (equivalent to a single persistent entity).

          As of this commit (in testing with kitchensink's ReferenceObject#moveChildren) can select multiple objects in the UI, but cannot yet invoke the action.

          Show
          jira-bot ASF subversion and git services added a comment - Commit fadb7ec780de2a714b96b444429464e3f8b59c07 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fadb7ec ] ISIS-785 : reworks ObjectAdapterMemento so can store a list of OAMs (equivalent to a transient list of persistent entities) as well as a single OAM (equivalent to a single persistent entity). As of this commit (in testing with kitchensink's ReferenceObject#moveChildren) can select multiple objects in the UI, but cannot yet invoke the action.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d62089eb7cd875192665ac76a1c8c23e4e618d80 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d62089e ]

          ISIS-785: huzzah... can now invoke actions also with a collection of objects.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d62089eb7cd875192665ac76a1c8c23e4e618d80 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d62089e ] ISIS-785 : huzzah... can now invoke actions also with a collection of objects.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 03b8f4ab4730703eddc170b2f220a1dbeb0e5256 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=03b8f4a ]

          ISIS-785: working towards supporting values types, also defaults. Not there yet.

          In particular:

          • extends ObjectAdapterMemento so that getObjectSpecId() is supported for both scalar and vector "sorts"
          • custom subclasses of Select2Choice and Select2MultiChoice to support this (holds the specId... also refactors/simplifies some code); simplify Select2 and remove Select2ChoiceUtil
          • extends ScalarModel#setObject(ObjectAdapter) so that can transparently handle an ObjectAdapter that's a list of pojos (eg as occurs when invoke the defaultXxx supporting method)
          • renamed ScalarModelWithMultiPending methods so ValuesChoicesSelect2Panel can implement it and also ScalarModelWithPending without there being a clash in the return type;
          • refactored ValuesChoicesSelect2Panel to use Select2 rather than Select2Choice
          Show
          jira-bot ASF subversion and git services added a comment - Commit 03b8f4ab4730703eddc170b2f220a1dbeb0e5256 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=03b8f4a ] ISIS-785 : working towards supporting values types, also defaults. Not there yet. In particular: extends ObjectAdapterMemento so that getObjectSpecId() is supported for both scalar and vector "sorts" custom subclasses of Select2Choice and Select2MultiChoice to support this (holds the specId... also refactors/simplifies some code); simplify Select2 and remove Select2ChoiceUtil extends ScalarModel#setObject(ObjectAdapter) so that can transparently handle an ObjectAdapter that's a list of pojos (eg as occurs when invoke the defaultXxx supporting method) renamed ScalarModelWithMultiPending methods so ValuesChoicesSelect2Panel can implement it and also ScalarModelWithPending without there being a clash in the return type; refactored ValuesChoicesSelect2Panel to use Select2 rather than Select2Choice
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 885b49419e00567aec33096a66a751c6122bd8d7 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=885b494 ]

          ISIS-785: removes println debug stmt from SpecificationLoader

          Show
          jira-bot ASF subversion and git services added a comment - Commit 885b49419e00567aec33096a66a751c6122bd8d7 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=885b494 ] ISIS-785 : removes println debug stmt from SpecificationLoader
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0419e4d7cd2be05eaeb0a83b1df287524e84e023 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0419e4d ]

          ISIS-785: extends common XSD (and therefore the other XSDs) to support action parameters that are collections.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0419e4d7cd2be05eaeb0a83b1df287524e84e023 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0419e4d ] ISIS-785 : extends common XSD (and therefore the other XSDs) to support action parameters that are collections.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bbb9d33539e0cbc9b753809e2c86f7036c911eb4 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bbb9d33 ]

          ISIS-785: fixes value select2 also (was only saving the first selected object, due to the ChoiceProvider implementation assuming there is only ever one choice selected (no longer true now, of course).

          Show
          jira-bot ASF subversion and git services added a comment - Commit bbb9d33539e0cbc9b753809e2c86f7036c911eb4 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bbb9d33 ] ISIS-785 : fixes value select2 also (was only saving the first selected object, due to the ChoiceProvider implementation assuming there is only ever one choice selected (no longer true now, of course).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d987650409fd33094ca6154a4e2cc86417bba556 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d987650 ]

          ISIS-785: tidies up code, removes differences in method names, factors out the ChoiceProviders out of ReferencePanel and ValueChoicesSelect2Panel.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d987650409fd33094ca6154a4e2cc86417bba556 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d987650 ] ISIS-785 : tidies up code, removes differences in method names, factors out the ChoiceProviders out of ReferencePanel and ValueChoicesSelect2Panel.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 50a38e9f9d43cc86a766341e96de781fd49cadf0 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=50a38e9 ]

          ISIS-785: feedback panel (indicating mandatory parameter etc) now shows for ReferencePanel.

          Along the way, the ReferencePanel#select2 field is not created eagerly (similar to ValueSelect2ChoicePanel) and never removed. There's a chance, at least, this might fix the floating drop-down problem.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 50a38e9f9d43cc86a766341e96de781fd49cadf0 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=50a38e9 ] ISIS-785 : feedback panel (indicating mandatory parameter etc) now shows for ReferencePanel. Along the way, the ReferencePanel#select2 field is not created eagerly (similar to ValueSelect2ChoicePanel) and never removed. There's a chance, at least, this might fix the floating drop-down problem.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1dc47eef783249dab8f2ff85fe2df7ee7095e2e3 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1dc47ee ]

          ISIS-785: fixes

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1dc47eef783249dab8f2ff85fe2df7ee7095e2e3 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1dc47ee ] ISIS-785 : fixes
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d1453c12b67019fb400802c70dad1aadc36d2062 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d1453c1 ]

          ISIS-785: extracts method in ReferencePanel to create select2 object

          Show
          jira-bot ASF subversion and git services added a comment - Commit d1453c12b67019fb400802c70dad1aadc36d2062 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d1453c1 ] ISIS-785 : extracts method in ReferencePanel to create select2 object
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 482286e2b5bbced62a5e01c1618ae38aea3be5c6 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=482286e ]

          ISIS-785: tidying up, moves methods from SpecificationLoader into either TypeOfFacet.Util or CollectionUtils (as static methods)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 482286e2b5bbced62a5e01c1618ae38aea3be5c6 in isis's branch refs/heads/maint-1.13.3 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=482286e ] ISIS-785 : tidying up, moves methods from SpecificationLoader into either TypeOfFacet.Util or CollectionUtils (as static methods)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 03b8f4ab4730703eddc170b2f220a1dbeb0e5256 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=03b8f4a ]

          ISIS-785: working towards supporting values types, also defaults. Not there yet.

          In particular:

          • extends ObjectAdapterMemento so that getObjectSpecId() is supported for both scalar and vector "sorts"
          • custom subclasses of Select2Choice and Select2MultiChoice to support this (holds the specId... also refactors/simplifies some code); simplify Select2 and remove Select2ChoiceUtil
          • extends ScalarModel#setObject(ObjectAdapter) so that can transparently handle an ObjectAdapter that's a list of pojos (eg as occurs when invoke the defaultXxx supporting method)
          • renamed ScalarModelWithMultiPending methods so ValuesChoicesSelect2Panel can implement it and also ScalarModelWithPending without there being a clash in the return type;
          • refactored ValuesChoicesSelect2Panel to use Select2 rather than Select2Choice
          Show
          jira-bot ASF subversion and git services added a comment - Commit 03b8f4ab4730703eddc170b2f220a1dbeb0e5256 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=03b8f4a ] ISIS-785 : working towards supporting values types, also defaults. Not there yet. In particular: extends ObjectAdapterMemento so that getObjectSpecId() is supported for both scalar and vector "sorts" custom subclasses of Select2Choice and Select2MultiChoice to support this (holds the specId... also refactors/simplifies some code); simplify Select2 and remove Select2ChoiceUtil extends ScalarModel#setObject(ObjectAdapter) so that can transparently handle an ObjectAdapter that's a list of pojos (eg as occurs when invoke the defaultXxx supporting method) renamed ScalarModelWithMultiPending methods so ValuesChoicesSelect2Panel can implement it and also ScalarModelWithPending without there being a clash in the return type; refactored ValuesChoicesSelect2Panel to use Select2 rather than Select2Choice
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 885b49419e00567aec33096a66a751c6122bd8d7 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=885b494 ]

          ISIS-785: removes println debug stmt from SpecificationLoader

          Show
          jira-bot ASF subversion and git services added a comment - Commit 885b49419e00567aec33096a66a751c6122bd8d7 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=885b494 ] ISIS-785 : removes println debug stmt from SpecificationLoader
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0419e4d7cd2be05eaeb0a83b1df287524e84e023 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0419e4d ]

          ISIS-785: extends common XSD (and therefore the other XSDs) to support action parameters that are collections.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0419e4d7cd2be05eaeb0a83b1df287524e84e023 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0419e4d ] ISIS-785 : extends common XSD (and therefore the other XSDs) to support action parameters that are collections.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bbb9d33539e0cbc9b753809e2c86f7036c911eb4 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bbb9d33 ]

          ISIS-785: fixes value select2 also (was only saving the first selected object, due to the ChoiceProvider implementation assuming there is only ever one choice selected (no longer true now, of course).

          Show
          jira-bot ASF subversion and git services added a comment - Commit bbb9d33539e0cbc9b753809e2c86f7036c911eb4 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bbb9d33 ] ISIS-785 : fixes value select2 also (was only saving the first selected object, due to the ChoiceProvider implementation assuming there is only ever one choice selected (no longer true now, of course).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d987650409fd33094ca6154a4e2cc86417bba556 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d987650 ]

          ISIS-785: tidies up code, removes differences in method names, factors out the ChoiceProviders out of ReferencePanel and ValueChoicesSelect2Panel.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d987650409fd33094ca6154a4e2cc86417bba556 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d987650 ] ISIS-785 : tidies up code, removes differences in method names, factors out the ChoiceProviders out of ReferencePanel and ValueChoicesSelect2Panel.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 50a38e9f9d43cc86a766341e96de781fd49cadf0 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=50a38e9 ]

          ISIS-785: feedback panel (indicating mandatory parameter etc) now shows for ReferencePanel.

          Along the way, the ReferencePanel#select2 field is not created eagerly (similar to ValueSelect2ChoicePanel) and never removed. There's a chance, at least, this might fix the floating drop-down problem.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 50a38e9f9d43cc86a766341e96de781fd49cadf0 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=50a38e9 ] ISIS-785 : feedback panel (indicating mandatory parameter etc) now shows for ReferencePanel. Along the way, the ReferencePanel#select2 field is not created eagerly (similar to ValueSelect2ChoicePanel) and never removed. There's a chance, at least, this might fix the floating drop-down problem.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d1453c12b67019fb400802c70dad1aadc36d2062 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d1453c1 ]

          ISIS-785: extracts method in ReferencePanel to create select2 object

          Show
          jira-bot ASF subversion and git services added a comment - Commit d1453c12b67019fb400802c70dad1aadc36d2062 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=d1453c1 ] ISIS-785 : extracts method in ReferencePanel to create select2 object
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 482286e2b5bbced62a5e01c1618ae38aea3be5c6 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=482286e ]

          ISIS-785: tidying up, moves methods from SpecificationLoader into either TypeOfFacet.Util or CollectionUtils (as static methods)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 482286e2b5bbced62a5e01c1618ae38aea3be5c6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=482286e ] ISIS-785 : tidying up, moves methods from SpecificationLoader into either TypeOfFacet.Util or CollectionUtils (as static methods)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a3b7770d1c6672d116f3a27b3d3f5743ef893bb7 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a3b7770 ]

          ISIS-785: fixes conflicts for merging maint-1.13.3 (Wicket 6.x) into master (Wicket 7.x)

          Show
          jira-bot ASF subversion and git services added a comment - Commit a3b7770d1c6672d116f3a27b3d3f5743ef893bb7 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a3b7770 ] ISIS-785 : fixes conflicts for merging maint-1.13.3 (Wicket 6.x) into master (Wicket 7.x)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit bf9b97a46507178243e66eed8b28d7ca36bd5d08 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf9b97a ]

          ISIS-785: removes the setRequired for reference and value select2

          ... because when triggered causes the floating drop-down issue to re-appear

          Show
          jira-bot ASF subversion and git services added a comment - Commit bf9b97a46507178243e66eed8b28d7ca36bd5d08 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=bf9b97a ] ISIS-785 : removes the setRequired for reference and value select2 ... because when triggered causes the floating drop-down issue to re-appear
          Hide
          danhaywood Dan Haywood added a comment -

          done as part of ISIS-785

          Show
          danhaywood Dan Haywood added a comment - done as part of ISIS-785
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 39034890510aea83428567f1a99bc8e5addcaea6 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3903489 ]

          ISIS-785: updates to the "fundamentals" guide, as prereq to being able to document new functionality.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 39034890510aea83428567f1a99bc8e5addcaea6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3903489 ] ISIS-785 : updates to the "fundamentals" guide, as prereq to being able to document new functionality.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 38a3289271302f3cbb208018343c5e52cedeedb2 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=38a3289 ]

          ISIS-785: further updates to fundamentals guide, now with section on collection action parameters

          Show
          jira-bot ASF subversion and git services added a comment - Commit 38a3289271302f3cbb208018343c5e52cedeedb2 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=38a3289 ] ISIS-785 : further updates to fundamentals guide, now with section on collection action parameters
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a008d9d7bbda6aa69f8d6d6dc38c10c1b88a6a57 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a008d9d ]

          ISIS-785: fix to CSS for multi-select

          Show
          jira-bot ASF subversion and git services added a comment - Commit a008d9d7bbda6aa69f8d6d6dc38c10c1b88a6a57 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a008d9d ] ISIS-785 : fix to CSS for multi-select
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4c4bd5392b484e7ef9ccfd062bfa1d79844907e6 in isis's branch refs/heads/maint-1.14.0 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4c4bd53 ]

          ISIS-785: fix to CSS for multi-select

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4c4bd5392b484e7ef9ccfd062bfa1d79844907e6 in isis's branch refs/heads/maint-1.14.0 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4c4bd53 ] ISIS-785 : fix to CSS for multi-select
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4c4bd5392b484e7ef9ccfd062bfa1d79844907e6 in isis's branch refs/heads/master from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4c4bd53 ]

          ISIS-785: fix to CSS for multi-select

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4c4bd5392b484e7ef9ccfd062bfa1d79844907e6 in isis's branch refs/heads/master from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=4c4bd53 ] ISIS-785 : fix to CSS for multi-select
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5666e4909a09692b93e0cb2f7c9ad25b3c82c816 in isis's branch refs/heads/maint-1.14.0 from Dan Haywood
          [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5666e49 ]

          ISIS-785: fixes multi-select for contributed actions and mixins

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5666e4909a09692b93e0cb2f7c9ad25b3c82c816 in isis's branch refs/heads/maint-1.14.0 from Dan Haywood [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5666e49 ] ISIS-785 : fixes multi-select for contributed actions and mixins

            People

            • Assignee:
              danhaywood Dan Haywood
              Reporter:
              oscarbou Oscar Bou
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development