Uploaded image for project: 'Causeway'
  1. Causeway
  2. CAUSEWAY-780

@Inject on field and @RequestScoped are incompatible - use a MetaModelValidator to detect

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • core-1.4.0
    • 2.0.0-M3
    • Core
    • None

    Description

      Our support for @RequestScoped annotation is home-grown; we create a Javassist proxy for the service, which then delegates to dynamically created instances of the actual service bound on a thread-local.

      The Javassist proxy automatically forwards all method calls to the underlying service for the current thread.

      If the request-scoped service has other services injected into it via methods (ie setXxx(...) or injectXxx(...), then these method calls are forwarded just like any other, and everything works fine.

      However, if the request-scoped service has its other services injected via a field annotated with @RequestScoped, then the service will be injected into the Javassist proxy and the underlying service will get a null pointer.

      One day we might replace our home-grown injection with a more sophisticated third-party library (eg a CDI impl?) that can handle the above. But until such time, as a workaround we should fail-fast: detect the situation and through an exception on start-up.

      Attachments

        Activity

          People

            danhaywood Daniel Keir Haywood
            danhaywood Daniel Keir Haywood
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: