[ISIS-665] ObjectActionImpl should escalate a thrown Isis ApplicationException to its underlying cause if the transaction is in a state of mustAbort.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: archetype-quickstart-wrj-1.3.1, objectstore-jdo-1.3.0, core-1.3.0
• Fix Version/s: archetype-quickstart-wrj-1.4.0, objectstore-jdo-1.4.0, core-1.4.0
• Component/s: Core, Core: Objectstore: JDO
• Assignee: Dan Haywood
• Reporter: Dan Haywood
• Created: 28/Jan/14 07:22
• Updated: 20/Feb/15 14:07
• Resolved: 03/Feb/14 11:29

Description

We hit a situation whereby a bug in the domain code was causing a JDOUserException to be thrown (missing a mandatory-field), but then throwing an org.apache.isis.applib.ApplicationException.

This exception is only intended for non-fatal exceptions. Isis therefore attempted to commit the transaction subsequently only to find it had already been aborted.

ObjectActionImpl should try to identify this programming error, and "do the right thing", which is probably to throw the ApplicationException's underlying cause (else a runtime exception if there is none).

NB: this ticket should also include adding some documentation to the website, since this is a pretty subtle issue.