Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-542

Restrict which entities a service action is contributed to (as either a contributed action or contributed assocation).

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: core-1.2.0
    • Fix Version/s: 1.13.0
    • Component/s: Core
    • Labels:
      None

      Description

      For example, an action

      void foo(A a, B b)

      { ... }

      will be contributed to both entities A and B. We might want to allow it to be contributed to one or the other.

      Suggestion is that @NotContributed annotation applies to action parameters (with current behaviour maintained for compatibility as the default for all parameters of the action):

      eg

      void foo(
      @NotContributed(As.Action) A,
      @NotContributed(As.Association) B) { ... }

        Activity

        Hide
        danhaywood Dan Haywood added a comment -

        The @Mixin support introduced in 1.11.1 basically addresses this.

        Show
        danhaywood Dan Haywood added a comment - The @Mixin support introduced in 1.11.1 basically addresses this.
        Hide
        jcvanderwal Jeroen van der Wal added a comment - - edited

        +2 from Jeroen & Johan

        Since we're using contributions more and more we like to start working on this issue. We suggest extending @ParameterLayout with a contributed parameter.

        Something like this:

        public class PartyContributions{
            public void moveFundsTo(
                final Party fromParty,
                final @ParameterLayout(contributed = Contributed.Never) Party toParty) {
                    ....
                }
        }
        
        Show
        jcvanderwal Jeroen van der Wal added a comment - - edited +2 from Jeroen & Johan Since we're using contributions more and more we like to start working on this issue. We suggest extending @ParameterLayout with a contributed parameter. Something like this: public class PartyContributions{ public void moveFundsTo( final Party fromParty, final @ParameterLayout(contributed = Contributed.Never) Party toParty) { .... } }

          People

          • Assignee:
            danhaywood Dan Haywood
            Reporter:
            danhaywood Dan Haywood
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development