Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-538

Improve performance of rendering lists (in Wicket viewer)

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: viewer-wicket-1.2.0
    • Fix Version/s: 2.3.0
    • Component/s: Core: Viewer: Wicket
    • Labels:
      None

      Description

      rendering a Lease, showing LeaseUnit in table (they would be in view mode). Even so, we compute the choices etc, even though never used (see stack trace).

      In ScalarPanelAbstract#buildGui(), we have:

      private void buildGui() {

      // REVIEW: this is nasty, both write to the same entityLink field
      // even though only one is used
      componentIfCompact = addComponentForCompact();
      componentIfRegular = addComponentForRegular();

      Brands.findUniqueNames() line: 46
      LeaseUnit.choicesBrandName() line: 278
      NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]
      NativeMethodAccessorImpl.invoke(Object, Object[]) line: not available
      DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: not available
      Method.invoke(Object, Object...) line: not available
      MethodExtensions.invoke(Method, Object, Object[]) line: 50
      MethodExtensions.invoke(Method, Object) line: 45
      AdapterInvokeUtils.invoke(Method, ObjectAdapter) line: 44
      PropertyChoicesFacetViaMethod.getChoices(ObjectAdapter, SpecificationLoader) line: 72
      OneToOneAssociationImpl.getChoices(ObjectAdapter) line: 248
      ScalarModel$Kind$1.getChoices(ScalarModel, ObjectAdapter[]) line: 163
      ScalarModel.getChoices(ObjectAdapter[]) line: 584
      ValueChoicesSelect2Panel.getChoiceMementos(ObjectAdapter[]) line: 93
      ValueChoicesSelect2Panel.setChoices(ObjectAdapter[]) line: 194
      ValueChoicesSelect2Panel.addComponentForRegular() line: 76
      ValueChoicesSelect2Panel(ScalarPanelAbstract).buildGui() line: 178
      ValueChoicesSelect2Panel(ScalarPanelAbstract).onBeforeRender() line: 147
      ValueChoicesSelect2Panel(Component).internalBeforeRender() line: 923
      ValueChoicesSelect2Panel(Component).beforeRender() line: 991

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              danhaywood Dan Haywood
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: