[ISIS-476] Update JDO/DN to allow for fact that invoking the Persisting callback may have resulted in the target object having already been updated.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: objectstore-jdo-1.1.0
• Fix Version/s: objectstore-jdo-1.3.0
• Component/s: Core: Objectstore: JDO
• Assignee: Dan Haywood
• Reporter: Dan Haywood
• Created: 23/Jul/13 05:07
• Updated: 25/Oct/13 08:47
• Resolved: 24/Jul/13 05:45

Description

This issue was found while working on Estatio app:

public class CommunicationChannel {

....

/**

• Isis callback
  */
  public void persisting() { owner.addToCommunicationChannels(this); }

  }

correctly generates the INSERT of the owner/CC tuple (eg into PARTY_COMMUNICATIONCHANNELS), but then Isis throws an exception.

The fix is to add a guard in DataNucleusSimplePersistAlgorithm:

public void makePersistent(final ObjectAdapter adapter,
final ToPersistObjectSet toPersistObjectSet) {
...
CallbackUtils.callCallback(adapter, PersistingCallbackFacet.class);
// the callback might have caused the adapter to become persistent.
if (alreadyPersistedOrNotPersistable(adapter))

{ return; }

...
}