[CAUSEWAY-3017] [Wicket Viewer] WebRequestCycleForIsis does not display recognizable error.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Resolved
• Affects Version/s: 2.0.0-M7
• Fix Version/s: 2.0.0-M8
• Component/s: Viewer Wicket
• Assignee: Andi Huber
• Reporter: Miklós Győrfi
• Created: 22/Apr/22 09:25
• Updated: 18/Mar/23 12:03
• Resolved: 22/Apr/22 13:33

Description

In WebRequestCycleForIsis onException there is a code:

val exceptionRecognizerService = getExceptionRecognizerService();
val recognizedIfAny = exceptionRecognizerService.recognize(ex);
if(recognizedIfAny.isPresent()) {
    return respondGracefully(cycle);
} 

So it recognizes the error, but does not display it.

 

Maybe

 

val exceptionRecognizerService = getExceptionRecognizerService();
val recognizedIfAny = exceptionRecognizerService.recognize(ex);
if(recognizedIfAny.isPresent()) {
    getMessageBroker().ifPresent(broker->{
        String msg = recognizedIfAny.get().toMessage(getCommonContext().getTranslationService());
        if (msg != null) {
            broker.addMessage(
                    msg);
        }
    });
    return respondGracefully(cycle);
}
 

could work well.