Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-2749

Convert IsisConverterLocator into a domain service and allow Wicket Converters to be substituted in.

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0-M5
    • Fix Version/s: 2.0.0-M7
    • Component/s: Isis Core
    • Labels:
      None

      Description

      For example, if enter 'abc' into a BigDecimal' then the error message returned is effectively hardcoded because in IsisWicketApplication we just use Wicket's default ConverterLocator (fine tuned with a couple of extra types to convert).  That means we get:

      We also have a bit of technical debt, because there is an IsisConverterLocator that doesn't implement Wicket's IConvertLocator, and is just called from one place, statically, to render an object as a string.

      So we should perhaps:

      • provide our own impl of IConveterLocator, probably subclassed from Wicket's
      • make it a Spring Bean
      • get rid of IsisConverterLocator (roll it into aforementioned IConverterLocator)
      • decide on a way to allow new/replacement converters to be registered.

      We might also want to look at the ValueTypeRegistry we have, just in case there's overlap.

       

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              danhaywood Daniel Keir Haywood

              Dates

              • Created:
                Updated:

                Issue deployment