[CAUSEWAY-2595] Translation context should be provided consistently for collections/properties/services ...

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Resolved
• Affects Version/s: 2.0.0-M5
• Fix Version/s: 2.0.0-M6
• Assignee: Andi Huber
• Reporter: Daniel Keir Haywood
• Created: 05/Apr/21 09:38
• Updated: 25/Aug/21 14:33
• Resolved: 08/Apr/21 15:21

Description

... as to whether an id or a name is used.

 

from https://the-asf.slack.com/archives/CFC42LWBV/p1617614189183900

 

Regarding translations, it seems that currently the ID of a collection is used as the reference text, not the name from the layout data

 
Line 317 in the GridSystemServiceAbstract class:
final String groupName = collectionLayoutData.getId();
final String sequence = "" + collectionSequence++;
addOrReplaceFacet(
new MemberOrderFacetXml(groupName, sequence, translationService, oneToManyAssociation));
groupName is then passed to the translation service as reference text
 
 
This is different from how properties work; (not looked at actions)
 
This is in the visitor for CollectionLayoutData.
 

~~~
To distill this: why are the IDs of layouts used as reference texts for translations ?
 
 
 

 
 

Issue Links

• links to: GitHub Pull Request #476