Uploaded image for project: 'Causeway'
  1. Causeway
  2. CAUSEWAY-2595

Translation context should be provided consistently for collections/properties/services ...

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Resolved
    • 2.0.0-M5
    • 2.0.0-M6
    • None
    • None

    Description

      ... as to whether an id or a name is used.

       

      from https://the-asf.slack.com/archives/CFC42LWBV/p1617614189183900

       

      Regarding translations, it seems that currently the ID of a collection is used as the reference text, not the name from the layout data

       
      Line 317 in the GridSystemServiceAbstract class:
      final String groupName = collectionLayoutData.getId();
      final String sequence = "" + collectionSequence++;
      addOrReplaceFacet(
      new MemberOrderFacetXml(groupName, sequence, translationService, oneToManyAssociation));
      groupName is then passed to the translation service as reference text
       
       
      This is different from how properties work; (not looked at actions)
       
      This is in the visitor for CollectionLayoutData.
       

      ~~~
      To distill this: why are the IDs of layouts used as reference texts for translations ?
       
       
       

       
       

      Attachments

        Issue Links

          Activity

            People

              hobrom Andi Huber
              danhaywood Daniel Keir Haywood
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: