[CAUSEWAY-2329] Support nested non-static mixins, with domain event class declared within.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0-M3
• Fix Version/s: 2.0.0-M6
• Component/s: Applib (programming model)
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 24/Mar/20 16:10
• Updated: 25/Aug/21 14:33
• Resolved: 27/Jul/21 10:14

Description

To support this, need to allow action domain events to have 1-arg constructor, being the mixee. 

eg, at the moment, in simpleapp, I can refactor updateName into a mixin:

public static class UpdateNameActionDomainEvent 
  extends SimpleModule.ActionDomainEvent<SimpleObject.updateName> { }

@Action(semantics = IDEMPOTENT,
        command = CommandReification.ENABLED, publishing = Publishing.DISABLED,
        associateWith = "name", domainEvent = UpdateNotesActionDomainEvent.class)
public class updateName {

    public SimpleObject act(@Name final String name) {
        setName(name);
        return SimpleObject.this;
    }

    public String default0Act() {
        return getName();
    }
}
 

but the  UpdateNameActionDomainEvent has to remain outside for now.  Instead, I'd like to write:

@Action(semantics = IDEMPOTENT,
        command = CommandReification.ENABLED, publishing = Publishing.DISABLED,
        associateWith = "name", domainEvent = UpdateNotesActionDomainEvent.class)
public class updateName {

   public class UpdateNameActionDomainEvent 
     extends SimpleModule.ActionDomainEvent<SimpleObject.updateName> { } 

    public SimpleObject act(@Name final String name) {
        setName(name);
        return SimpleObject.this;
    }

    public String default0Act() {
        return getName();
    }
}
 

The fix should be quite simple: improve the instantiation logic in DomainEventHelper to handle events with 1 arg as well as 0 args and 3 args.

Issue Links

• links to: GitHub Pull Request #688