Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-2255

In WrapperFactory, lookup mixin properties and collections (as well as actions).

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-M3
    • Component/s: None
    • Labels:
      None

      Description

      Because we are now more strict about the bookmarks that can be created (in particular, because we do not allow bookmarks to be created on transient objects such as mixins), then the previous code was failing when attempting to create an InteractionDto with a bookmark to a mixin.

      Tracking this down, this was because of the invocation of a contributed collection via the WrapperFactory.  The WrapperFactory (more precisely, DomainObjectInvocationHandler) attempts to do a "reverse-looking" to find the contributed mixed member  from the original action on the mixin, but only searched for contributed actions, and did not consider contributed properties or collections.

      This change is to fix this.  It should mean that the targetAdapter for InteractionDto's is always correct, and that memberIdentifier == logicalMemberIdentifier in all cases.

        Attachments

          Activity

            People

            • Assignee:
              danhaywood Daniel Keir Haywood
              Reporter:
              danhaywood Daniel Keir Haywood
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: