Uploaded image for project: 'Isis'
  1. Isis
  2. ISIS-2253

Derive ChoicesFacet from AssociatedWithFacet, remove special-case logic.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Isis Viewer Wicket
    • Labels:
      None

      Description

      In fact, this is a case of two wrongs not quite making a right. There's a nasty hack in that it is the Wicket viewer that knows how to populate the choices for the parameter, and it does this without looking for an autoComplete or choices facet ; it just picks up the checked items of the associated collection.

      The short term solution to fix DemoApp is just to update that metamodel validator to also take into account any AssociatedWithFacet.

      The long term "correct" solution is a new facet factory that will derive a ChoicesFacet from the AssociatedWithFacet, and then to remove the special case logic from the Wicket viewer.

      That would then make the validator correct as it is now written.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                hobrom Andi Huber
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: