[CAUSEWAY-2235] Mixins declared using @Property, @Collection or @Action should emit domain events

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-RC2
• Component/s: Core
• Assignee: Daniel Keir Haywood
• Reporter: Daniel Keir Haywood
• Created: 01/Jan/20 14:15
• Updated: 05/Jun/23 14:14
• Resolved: 05/Jun/23 14:14

Description

More straightforwardly, Object_logicalTypeName mixin doesn't emit events of any sort (that I can find).  It ought to emit a property domain event, as declared by @Property(domainEvent=...).

That suggests executing some facets associated with the OneToOneAssociationMixedIn, perhaps could be installed using a PostProcessor (which acts after the mixin members exist).

 

~~~

Original problem as raised:

In particular, doesn't properly create domain events if abstract and invoke via the wrapper (ie during integ tests)

fix? don't use getDeclaredFields, instead getFields (I think... to test)

example in estatio - HasDocumentAbstract_categoriseAbstract subclasses.

~~~
because of https://github.com/apache/isis/blob/69b4859f27ce857e9af75b7d1ef0ae7b42e5cc2c/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/mixin/MixinFacetAbstract.java#L97

getDeclaredFields() rather than getFields()

~~~~

 

for example, with this mixin:

@Property
public class SimpleObject_self {
    private final SimpleObject simpleObject;

    public SimpleObject_self(SimpleObject simpleObject) {
        this.simpleObject = simpleObject;
    }

    @ActionLayout(contributed = Contributed.AS_ASSOCIATION)
    public SimpleObject prop() {
        return simpleObject;
    }

}
 

it's necessary to specify @ActionLayout, otherwise the behaviour is contributed as both an association and an action.

The @ActionLayout should be inferred.

~~~

See the same for @Collection and @Action also ... should imply AS_ASSOCIATION and AS_ACTION respectively.

~~~

Also, (and this might be a slightly different issue), the facets defined by @Property(...) should be copied down correctly to the corresponding facets on the action, eg domain event (this might need specifying more precisely...)

 

 

Issue Links

• is duplicated by: CAUSEWAY-2650 [DUPLICATE] Support domain events for property and collection mixins
• is fixed by: CAUSEWAY-3409 The 'executing' and 'executed' domain events don't fire for mixin actions; see demo app.
• relates to: CAUSEWAY-2492 Metamodel contributing members are not inheritable from abstract super class.